Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S3 sync bug in setting modified time on multi-part downloads #1072

Closed
kirat-singh opened this issue Dec 23, 2014 · 1 comment · Fixed by #1102
Closed

S3 sync bug in setting modified time on multi-part downloads #1072

kirat-singh opened this issue Dec 23, 2014 · 1 comment · Fixed by #1102
Labels
bug This issue is a bug. s3

Comments

@kirat-singh
Copy link

Hi there,

I don't have a reproducible test case, but multi-part downloads incorrectly set the mtime of the file before closing it. This can cause the time to be reset to now when the file is closed.

I have a very simple patch to fix this issue as a pull request and have been running this patched version on our production servers since Nov 10.

Please do take a look so I don't have to keep my patch around.

#994

best,
-Kirat
@jamesls
Copy link
Member

jamesls commented Dec 23, 2014

Thanks, I'll take a look. One of the things we typically do before merging bug fix PRs is to try to get a test case written, both to ensure that a) the bug is confirmed fixed and b) we can prevent this bug from surfacing again. I'll try to see if I can get a test case written for this.

@jamesls jamesls added the investigating This issue is being investigated and/or work is in progress to resolve the issue. label Dec 23, 2014
@jamesls jamesls added bug This issue is a bug. s3 accepted and removed bug This issue is a bug. investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Jan 16, 2015
jamesls added a commit to jamesls/aws-cli that referenced this issue Jan 17, 2015
@jamesls
Set mtime of S3 downloaded object when file is closed
0f2b750 
This is the original patch from @kirat-singh, but the forked
repo is no longer available.

I've added a unit test for this that shows that the mtime modification
is tied to the execution of an IOCloseRequest instead of the enqueuing
of the IOCloseRequest.

Fixes aws#1072
Closes aws#994
@jamesls jamesls mentioned this issue Jan 17, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug. s3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set mtime of S3 downloaded object when file is closed jamesls/aws-cli
2 participants
@jamesls @kirat-singh