Set mtime of S3 downloaded object when file is closed #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the original patch from @kirat-singh, but the forked repo is no longer available. I've added a unit test for this that shows that the mtime modification is tied to the execution of an IOCloseRequest instead of the enqueuing of the IOCloseRequest. Fixes aws#1072 Closes aws#994
|
Not sure what's going on with coveralls. The only branch I added that could have decreased coverage definitely has test coverage. From coverage.py directly: Note lines 179-181 are covered. Feel free to review and let me know if you can see anything I've missed for tests. |
|
LGTM 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the original patch from @kirat-singh, but the forked
repo is no longer available.
I've added a unit test for this that shows that the mtime modification
is tied to the execution of an IOCloseRequest instead of the enqueuing
of the IOCloseRequest.
Fixes #1072
Closes #994
cc @kyleknap @danielgtaylor