Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue in cloning app templates repo in windows #3950

Merged
merged 8 commits into from
Jun 9, 2022

Conversation

hawflau
Copy link
Contributor

@hawflau hawflau commented Jun 8, 2022

Which issue(s) does this change fix?

#3946

Why is this change necessary?

App templates repo contains some very long paths in which Windows doesn't support them as it has a limitation of 260 chars.

How does it address the issue?

This change modifies the git clone command by appending --config core.longpaths=true if the system is Windows. The config is only applied for the cloned repo (i.e. the app templates repo) and won't affect user's system settings.

What side effects does this change have?

No

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hawflau hawflau enabled auto-merge (squash) June 9, 2022 18:31
@hawflau hawflau merged commit 33f4b97 into aws:develop Jun 9, 2022
@hawflau hawflau deleted the fix-win-longpaths branch July 2, 2022 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants