Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced the length of the cloned app template folder name #4542

Merged
merged 4 commits into from
Jan 6, 2023

Conversation

lucashuy
Copy link
Contributor

@lucashuy lucashuy commented Jan 5, 2023

Why is this change necessary?

This is one of the changes being made to help reduce the overall length of cloned app templates to avoid reaching the maximum path length in Windows.

How does it address the issue?

Changes the folder name from aws-sam-cli-app-templates to tmpl for Windows machines.

What side effects does this change have?

Existing Windows installations with an aws-sam-cli-app-templates folder in their %appdata%/AWS SAM directory will have that folder remain there until it is manually deleted.

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lucashuy lucashuy marked this pull request as ready for review January 5, 2023 23:51
@lucashuy lucashuy requested a review from a team as a code owner January 5, 2023 23:51
@lucashuy lucashuy requested review from jfuss and qingchm January 5, 2023 23:51
Copy link
Contributor

@hawflau hawflau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with question - With this change, does that mean we can/should revert PR #3950?

@lucashuy
Copy link
Contributor Author

lucashuy commented Jan 6, 2023

Approved with question - With this change, does that mean we can/should revert PR #3950?

From what I can gather, we can just leave that PR fix in place since its not changing anything about the way we digest the templates. Even though we could remove it since we are now reducing the paths of our templates, imo it doesn't hurt to leave it in so that we know that this won't happen with git in the future.

@hawflau hawflau enabled auto-merge (squash) January 6, 2023 22:28
@hawflau hawflau merged commit 4116b9f into aws:develop Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants