move common middleware stack ops to service client modules #2516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucix-aws
commented
Feb 22, 2024
| goDelegator.useFileWriter("api_client.go", settings.getModuleName(), addMiddleware()); | ||
| } | ||
|
|
||
| // TODO symbols |
There was a problem hiding this comment.
The commit two entries down addresses this: 0d1b977
wty-Bryant
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the majority of the work for #2507, though it doesn't completely address it, as some smithy-side middlewares and service-specific ones (e.g. flex checksums) remain.
This is a net-zero change behaviorally, as the new snapshot tests will indicate.
I've also removed golangci-lint from the workflows, we don't really pay attention to it and it seems to be overopinionated in a lot of different ways that don't necessarily mesh w/ codegen (e.g. unused unexported funcs).