Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/ini: add support for ini parser #2210

Merged
merged 5 commits into from
Oct 19, 2018
Merged

internal/ini: add support for ini parser #2210

merged 5 commits into from
Oct 19, 2018

Conversation

xibz
Copy link
Contributor

@xibz xibz commented Oct 15, 2018

New PR since rebasing the old one was intense.

ini parser uses an LL(1) parser to generate a list of sections from an ini file or bytes.
This change will get rid of a dependency and below is the benchmark data for this change:

BenchmarkINIParser-4              100000             15926 ns/op           13312 B/op         45 allocs/op
BenchmarkGoINIParser-4            200000              7393 ns/op            8528 B/op         65 allocs/op

See #2024 for more information.

@xibz xibz requested a review from jasdel October 15, 2018 23:33
@jasdel
Copy link
Contributor

jasdel commented Oct 16, 2018

also should update the go.mod file dependencies.

@emmanuel
Copy link

emmanuel commented Nov 16, 2018

Great perf. But the behavior changed without warning: #2281

(To be clear, perhaps more than one space between LHS tokens and equals sign was never intended to be supported. Whatever the intent; it used to work, and now it doesn't.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants