feat(middleware-api-key): add new auth middleware #4012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardomourar
force-pushed
the
feat/middleware-token-without-default-provider
branch
from
b96a8bb to
1d8c409
Compare
eduardomourar
changed the title
kuhe
reviewed
Oct 4, 2022
kuhe
requested changes
Oct 4, 2022
eduardomourar
force-pushed
the
feat/middleware-token-without-default-provider
branch
from
ecfed07 to
6b856b3
Compare
eduardomourar
force-pushed
the
feat/middleware-token-without-default-provider
branch
from
6b856b3 to
52c7834
Compare
kuhe
approved these changes
Oct 5, 2022
eduardomourar
force-pushed
the
feat/middleware-token-without-default-provider
branch
2 times, most recently
from
37ccd95 to
a14a5b3
Compare
|
I have created another PR with formatting issues: #4087 |
eduardomourar
force-pushed
the
feat/middleware-token-without-default-provider
branch
3 times, most recently
from
7f7a613 to
a7bab48
Compare
eduardomourar
force-pushed
the
feat/middleware-token-without-default-provider
branch
from
a7bab48 to
67fd30e
Compare
eduardomourar
force-pushed
the
feat/middleware-token-without-default-provider
branch
2 times, most recently
from
9cd5fe4 to
8db1050
Compare
trivikr
requested changes
Dec 15, 2022
trivikr
requested changes
Dec 15, 2022
eduardomourar
force-pushed
the
feat/middleware-token-without-default-provider
branch
from
1ef5489 to
d8e9485
Compare
We will create a new middleware to handle API keys in the context of Smithy generated models (probably not applicable for AWS specific services). The code is based heavily on [this PR]( smithy-lang/smithy-typescript#473 ) from the Smithy TypeScript repository. In order for it to work, we need to ensure the Bearer token middleware succeeds even when the `token` is not set.
eduardomourar
force-pushed
the
feat/middleware-token-without-default-provider
branch
from
d8e9485 to
db8e8e4
Compare
|
@trivikr , could this be re-approved and merged, please? |
kuhe
approved these changes
Jan 24, 2023
trivikr
approved these changes
Jan 24, 2023
eduardomourar
deleted the
feat/middleware-token-without-default-provider
branch
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue N/A
Description
We will create a new middleware to handle API keys in the context of Smithy generated models (probably not applicable for AWS specific services). The code is based heavily on this PR from the Smithy TypeScript repository.
In order for it to work, we need to ensure the Bearer token middleware succeeds even when the
tokenis not set.Testing
Unit tests
Additional context
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.