Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix formatting with prettier #4087

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

eduardomourar
Copy link
Contributor

@eduardomourar eduardomourar commented Oct 25, 2022

Issue

N/A

Description

Only fixing formatting on files using prettier.

  • Prettier version: v2.7.1 (as specified in package.json)
  • Command used: npx prettier --write '**/*.{ts,js,md,json}'

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr
Copy link
Member

trivikr commented Oct 25, 2022

@eduardomourar Thanks for the PR!
Can you remove formatting from aws-models folder? We're in the middle of doing a batch update for clients.

Also, in the PR description can you add prettier version used, and the command run to perform formatting?
We perform auto formatting on file save and precommit. So, I'm curious how these were missed, and will look into it.

@eduardomourar
Copy link
Contributor Author

@eduardomourar Thanks for the PR! Can you remove formatting from aws-models folder? We're in the middle of doing a batch update for clients.

Also, in the PR description can you add prettier version used, and the command run to perform formatting? We perform auto formatting on file save and precommit. So, I'm curious how these were missed, and will look into it.

Ideally, prettier/eslint should also run as part of the github workflows to avoid drift because precommit can be misconfigured or bypassed altogether.

@trivikr trivikr merged commit 6bfdb02 into aws:main Oct 26, 2022
@eduardomourar eduardomourar deleted the chore/fix-formatting branch October 27, 2022 09:47
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants