-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if action mailbox config is defined #135
Conversation
@ssunday @bobf Sorry to bother - but do you think this will fix #133? I think it would but I think there's something smelly about this as it is currently. I tried using |
@mullermp No idea. This seems like it makes sense, but I don't know that much about railties/etc. |
It's a low-key problem with this gem is that it's providing all sorts of functionality even if you don't want it. Like it's pulling in aws gems that you may not need. |
We made the decision a few years ago to bundle all the features because it's 1) easier for us to manage (develop/release) and 2) more "all in one" and "works out of the box" like rails is itself. I think we want to keep this pattern but I agree we can probably not bring in SDK gems as dependencies but rather check if they are loaded and enable those features as such. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll approve but 🤷🏻
Potentially fixes #133