Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if action mailbox config is defined #135

Merged
merged 5 commits into from
Jul 22, 2024
Merged

Check if action mailbox config is defined #135

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
840b9c2
Set action mailbox config inside initializer
mullermp Jul 22, 2024
a43b0da
Check if action mailbox config is defined
mullermp Jul 22, 2024
d9ae33a
Check if action mailbox engine is defined instead
mullermp Jul 22, 2024
3acb180
Push down defined check
mullermp Jul 22, 2024
009644f
Add changelog
mullermp Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/aws/rails/action_mailbox/engine.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
# frozen_string_literal: true

require 'action_mailbox/engine'

module Aws
module Rails
module ActionMailbox
# @api private
class Engine < ::Rails::Engine
config.action_mailbox.ses = ActiveSupport::OrderedOptions.new
config.action_mailbox.ses.s3_client_options ||= {}
if config.respond_to?(:action_mailbox)
mullermp marked this conversation as resolved.
Show resolved Hide resolved
config.action_mailbox.ses = ActiveSupport::OrderedOptions.new
config.action_mailbox.ses.s3_client_options ||= {}
end

initializer 'aws-sdk-rails.mount_engine' do |app|
mullermp marked this conversation as resolved.
Show resolved Hide resolved
app.routes.append do
Expand Down
1 change: 1 addition & 0 deletions spec/dummy/config/application.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
require 'action_controller/railtie'
require 'action_mailer/railtie'
require 'action_view/railtie'
require 'action_mailbox/engine'
require 'aws-sdk-rails'

module Dummy
Expand Down