Cannot get an EC2 request ID

[abe4tawa8]

This code cannot get an EC2 request ID.

region = "us-east-1"
client = Aws::EC2::Client.new(region: region)
response = client.describe_instances
response.context[:request_id]

=> nil

Aws::Plugins::Protocols::EC2#parse_xml method passes a block to Aws::Xml::Parser#parse method.
https://github.com/aws/aws-sdk-ruby/blob/master/aws-sdk-core/lib/aws-sdk-core/plugins/protocols/ec2.rb#L12-L21

          def parse_xml(context)
            if rules = context.operation.output
              data = Xml::Parser.new(rules).parse(xml(context)) do |h|
                context.metadata[:request_id] = h['requestId']
              end
              data
            else
              EmptyStructure.new
            end
          end

But Aws::Xml::Parser#parse method does not treat a block.
https://github.com/aws/aws-sdk-ruby/blob/master/aws-sdk-core/lib/aws-sdk-core/xml/parser.rb#L23-L31

      # @param [String] xml An XML document string to parse.
      # @param [Structure] target (nil)
      # @return [Structure]
      def parse(xml, target = nil)
        xml = '<xml/>' if xml.nil? or xml.empty?
        stack = Stack.new(@rules, target)
        @engine.new(stack).parse(xml.to_s)
        stack.result
      end

52f3efa#diff-91359190dca8b9e40db446ea5c1a5654

 -      # @param [String<xml>] xml
 -      # @param [Hash, nil] target
 +      # @param [String] xml An XML document string to parse.
 +      # @param [Structure] target (nil)
        # @return [Structure]
 -      def parse(xml, target = nil, &block)
 -        xml = MultiXml.parse(xml).values.first || {}
 -        yield(xml) if block_given?
 -        structure(@shape, xml, target)
 +      def parse(xml, target = nil)
 +        xml = '<xml/>' if xml.nil? or xml.empty?
 +        stack = Stack.new(@shape, target)
 +        @engine.new(stack).parse(xml)
 +        stack.result
        end

[awood45]

Thanks for the report and details, will take a look at why this is happening.

[awood45]

Okay, pretty clear on things now, and can certainly see that the block is no longer being hit anywhere.

I'm looking in to the right fix now.

[trevorrowe]

I've submitted a PR that addresses this issue and adds a supporting test.

[trevorrowe]

This has been merged and will be part of our next release.

[abe4tawa8]

Thank you for fixing this issue. 😄