Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup warnings #1057

Merged
merged 2 commits into from
Jan 13, 2016
Merged

Cleanup warnings #1057

merged 2 commits into from
Jan 13, 2016

Conversation

mkrisher
Copy link
Contributor

This PR removes an unused variable and an unused method (that assigned two unused variables). I'm using the gem in a project that has warnings turned on and Ruby 2.0 was complaining:

/var/lib/gems/2.0.0/gems/aws-sdk-resources-2.2.9/lib/aws-sdk-resources/services/s3/bucket.rb:44: warning: assigned but unused variable - error

/var/lib/gems/2.0.0/gems/aws-sdk-core-2.2.9/lib/aws-sdk-core/rest/request/endpoint.rb:105: warning: assigned but unused variable - param_name
/var/lib/gems/2.0.0/gems/aws-sdk-core-2.2.9/lib/aws-sdk-core/rest/request/endpoint.rb:106: warning: assigned but unused variable - param_value

I have a few more warnings to work through, but going to do in a followup PR in order to keep these small and clean.

@awood45
Copy link
Member

awood45 commented Jan 13, 2016

Looks good on a first pass, I want to take a deeper look into querystring_param before merging.

@mkrisher
Copy link
Contributor Author

Sounds good. fwiw, a quick ack on the repo didn't return any matches for 'querystring_param' other than the method when it existed.

@trevorrowe
Copy link
Member

+1, these changes look fine to merge.

awood45 added a commit that referenced this pull request Jan 13, 2016
@awood45 awood45 merged commit 3b30366 into aws:master Jan 13, 2016
@awood45
Copy link
Member

awood45 commented Jan 13, 2016

Thanks! Happy to look at more of these too, if you find more warnings.

@mkrisher
Copy link
Contributor Author

No problem, I am seeing and plan on tracking down the following as well:

/var/lib/gems/2.0.0/gems/aws-sdk-resources-2.2.9/lib/aws-sdk-resources/services/s3/object.rb:44: warning: method redefined; discarding old copy_from
/var/lib/gems/2.0.0/gems/aws-sdk-resources-2.2.9/lib/aws-sdk-resources/operation_methods.rb:18: warning: previous definition of copy_from was here
/var/lib/gems/2.0.0/gems/aws-sdk-resources-2.2.9/lib/aws-sdk-resources/services/s3/object_summary.rb:11: warning: method redefined; discarding old copy_from
/var/lib/gems/2.0.0/gems/aws-sdk-resources-2.2.9/lib/aws-sdk-resources/operation_methods.rb:18: warning: previous definition of copy_from was here

@mkrisher mkrisher deleted the cleanup_warnings branch January 13, 2016 21:56
awood45 added a commit that referenced this pull request Jan 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants