Setting app.debug does not propagate to app.log logger log level #386
Labels
Comments
stealthycoin
pushed a commit
to stealthycoin/chalice
that referenced
this issue
Jul 31, 2017
Debug mode can be set with `app.debug = True` which does not update the logger level from ERROR to DEBUG. This is has been replaced with a setter that reconfigures the log level after debug is reset. The initialization method on the Chalice class had some logic that checked what the debug value was and configured the logger to match; however, debug was hardcoded to be False so this never did anything useful. A debug parameter has been added to the the __init__ method to make this more useful, it defaults to False. fixes aws#386
stealthycoin
pushed a commit
to stealthycoin/chalice
that referenced
this issue
Jul 31, 2017
Debug mode can be set with `app.debug = True` which does not update the logger level from ERROR to DEBUG. This is has been replaced with a setter that reconfigures the log level after debug is reset. The initialization method on the Chalice class had some logic that checked what the debug value was and configured the logger to match; however, debug was hardcoded to be False so this never did anything useful. A debug parameter has been added to the the __init__ method to make this more useful, it defaults to False to be the same as the hardcoded value. fixes aws#386
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In https://github.com/awslabs/chalice/blob/master/chalice/app.py#L434-L437, intent is shown to set the logger's log level according to the value of Chalice.debug. However, app.debug is currently hardcoded to false in
Chalice.__init__, so without callingChalice. _configure_logging()again or setting it manually viaapp.log.setLevel(logging.DEBUG), it will always remain set to logging.ERROR.It would probably make more sense to have a
Chalice.debugsetter that also sets the logger's level, and/or have aChalice(debug=True)kwarg to make the code linked above behave as expected.The text was updated successfully, but these errors were encountered: