Fix log level out of sync with debug mode #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesls
approved these changes
Jul 31, 2017
kyleknap
reviewed
Jul 31, 2017
| @@ -418,12 +418,12 @@ class Chalice(object): | |||
|
|
|||
| FORMAT_STRING = '%(name)s - %(levelname)s - %(message)s' | |||
|
|
|||
| def __init__(self, app_name, configure_logs=True, env=None): | |||
| def __init__(self, app_name, debug=False, configure_logs=True, env=None): | |||
There was a problem hiding this comment.
Do we want to put this argument at the end just in case users are providing these options as positional arguments?
There was a problem hiding this comment.
My preference given we're pre GA is to order them based on frequent usage and I would expect debug to be more common than the other options. So I vote to keep it as is.
There was a problem hiding this comment.
Alright that's fine with me. Just wanted to make sure people were aware of it.
Debug mode can be set with `app.debug = True` which does not update the logger level from ERROR to DEBUG. This is has been replaced with a setter that reconfigures the log level after debug is reset. The initialization method on the Chalice class had some logic that checked what the debug value was and configured the logger to match; however, debug was hardcoded to be False so this never did anything useful. A debug parameter has been added to the the __init__ method to make this more useful, it defaults to False to be the same as the hardcoded value. fixes aws#386
stealthycoin
force-pushed
the
fix-debug-mode-log-level
branch
from
ff20f8a to
71f153a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debug mode can be set with
app.debug = Truewhich does not updatethe logger level from ERROR to DEBUG. This is has been replaced with a
setter that reconfigures the log level after debug is reset. The
initialization method on the Chalice class had some logic that checked
what the debug value was and configured the logger to match; however,
debug was hardcoded to be False so this never did anything useful. A
debug parameter has been added to the the init method to make this
more useful, it defaults to False.
fixes #386
cc @jamesls @kyleknap