Fix regression when using role arn in package command #794
+17
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need a noop method for precreated roles in the template generator. This was missed in testing because the models were directly passed to the template generator instead of using the dependency builder. In this case we were only passing the LambdaFunction resource to the template generator, but in reality we'd also pass the `models.IAMRole` resource as well because it's a dependency of the lambda function. Fixes aws#793.
Codecov Report
@@ Coverage Diff @@
## master #794 +/- ##
==========================================
+ Coverage 94.92% 94.93% +<.01%
==========================================
Files 21 21
Lines 3667 3669 +2
Branches 471 471
==========================================
+ Hits 3481 3483 +2
Misses 124 124
Partials 62 62
Continue to review full report at Codecov.
|
stealthycoin
approved these changes
Apr 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need a noop method for precreated roles in the template generator.
This was missed in testing because the models were directly
passed to the template generator instead of using the
dependency builder. In this case we were only passing the
LambdaFunction resource to the template generator, but
in reality we'd also pass the
models.IAMRoleresourceas well because it's a dependency of the lambda function.
Fixes #793.