Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cross account issue #1283

Merged
merged 2 commits into from
Sep 12, 2022
Merged

fix cross account issue #1283

merged 2 commits into from
Sep 12, 2022

Conversation

vincentni
Copy link
Member

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 9, 2022
@eks-distro-bot eks-distro-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 9, 2022
@junshun
Copy link
Member

junshun commented Sep 12, 2022

/lgtm
/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: junshun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@junshun
Copy link
Member

junshun commented Sep 12, 2022

goharbor/harbor#15388

Putting upstream issue here to keep track of.
We should get this change upstream if it works.

@vincentni
Copy link
Member Author

goharbor/harbor#17533

The change is also upstreamed.

@eks-distro-bot eks-distro-bot merged commit ee7e5a6 into aws:main Sep 12, 2022
@vincentni vincentni deleted the harbor-fix-cross-account-issue branch September 12, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants