Fix cross account issue #17533
Merged
Fix cross account issue #17533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentni
force-pushed
the
aws-ecr-cross-account-fix
branch
2 times, most recently
from
7385a82 to
41ffea1
Compare
|
@bitsf @stonezdj @steven-zou @ywk253100 Could you please give it a look? Thank you! |
Signed-off-by: Vincent Ni <[email protected]>
vincentni
force-pushed
the
aws-ecr-cross-account-fix
branch
from
41ffea1 to
6714d59
Compare
chlins
added
replication/adapters
Codecov Report
@@ Coverage Diff @@
## main #17533 +/- ##
==========================================
+ Coverage 67.25% 67.28% +0.02%
==========================================
Files 990 990
Lines 84048 84048
Branches 2625 2625
==========================================
+ Hits 56526 56548 +22
+ Misses 23674 23650 -24
- Partials 3848 3850 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bitsf
approved these changes
Sep 15, 2022
sluetze
pushed a commit
to sluetze/harbor
that referenced
this pull request
Oct 29, 2022
Signed-off-by: Vincent Ni <[email protected]>
mcsage
pushed a commit
to mcsage/harbor
that referenced
this pull request
Feb 16, 2023
Signed-off-by: Vincent Ni <[email protected]> Signed-off-by: Stephan Hohn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Pass in the correct endpoint to AWS ECR client config, so at the time of fetching token, the token will be valid for the target endpoint.
Issue being fixed
Fixes #(issue)
Currently, when AWS ECR client is created, it defaults the endpoint to whatever AWS_ACCESS_KEY_ID belongs to and thus falls short in the cross account case. The proposed fix sets the endpoint explicitly so it works in all cases.
Please indicate you've done the following: