Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve new dev experience in README #674

Merged
merged 4 commits into from
Mar 5, 2019
Merged

Conversation

andremoeller
Copy link
Contributor

@andremoeller andremoeller commented Mar 1, 2019

Description of changes:

Some README improvements for new devs.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Mar 1, 2019

Codecov Report

Merging #674 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #674   +/-   ##
=======================================
  Coverage   92.73%   92.73%           
=======================================
  Files          71       71           
  Lines        5489     5489           
=======================================
  Hits         5090     5090           
  Misses        399      399

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc70fd6...0d1a3f8. Read the comment docs.

Copy link
Contributor

@laurenyu laurenyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this!

README.rst Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
@andremoeller andremoeller force-pushed the master branch 2 times, most recently from 0d1a3f8 to 6222b92 Compare March 1, 2019 18:37
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
@jesterhazy
Copy link
Contributor

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

laurenyu
laurenyu previously approved these changes Mar 4, 2019
@jesterhazy
Copy link
Contributor

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jesterhazy
Copy link
Contributor

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jesterhazy
Copy link
Contributor

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jesterhazy
Copy link
Contributor

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jesterhazy jesterhazy merged commit a815279 into aws:master Mar 5, 2019
mizanfiu pushed a commit to mizanfiu/sagemaker-python-sdk that referenced this pull request Dec 13, 2022
Co-authored-by: Zhenshan Jin <[email protected]>
Co-authored-by: Judy Heflin <[email protected]>
Co-authored-by: Zhenshan Jin <[email protected]>

@Zhenshan-Jin
feature: add create model card (aws#663) 

@Zhenshan-Jin
feature: add read update delete model card (aws#671) 

@Zhenshan-Jin
feature: model overview and training details autodiscovery (aws#674) 

@Zhenshan-Jin
feature: add metrics for training and evaluation details (aws#680) 

@Zhenshan-Jin
feature: model card export & list model card version history (aws#688) 

@Zhenshan-Jin
fix: batch update model card and bugs fixes (aws#712) 

@Zhenshan-Jin
@judyheflin
documentation: Amazon SageMaker Model Cards Python SDK documentation (aws#716)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants