add notebook test to ci builds #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
nadiaya
previously approved these changes
Mar 4, 2019
buildspec.yml
Outdated
| @@ -19,6 +19,33 @@ phases: | |||
| AWS_CONTAINER_CREDENTIALS_RELATIVE_URI= AWS_DEFAULT_REGION= | |||
| tox -e py27,py36 -- tests/unit | |||
|
|
|||
| # run notebook test | |||
| - | | |||
| if has-matching-changes "tests/" "src/*.py" "docker/*/Dockerfile"; then | |||
There was a problem hiding this comment.
We don't need to run notebooks tests of someone touched 'tests/', do we?
There was a problem hiding this comment.
good point. i copied the check from the integ test guard. i will narrow it.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
nadiaya
approved these changes
Mar 4, 2019
mizanfiu
pushed a commit
to mizanfiu/sagemaker-python-sdk
that referenced
this pull request
Dec 13, 2022
Co-authored-by: Zhenshan Jin <[email protected]> Co-authored-by: Judy Heflin <[email protected]> Co-authored-by: Zhenshan Jin <[email protected]> @Zhenshan-Jin feature: add create model card (aws#663) @Zhenshan-Jin feature: add read update delete model card (aws#671) @Zhenshan-Jin feature: model overview and training details autodiscovery (aws#674) @Zhenshan-Jin feature: add metrics for training and evaluation details (aws#680) @Zhenshan-Jin feature: model card export & list model card version history (aws#688) @Zhenshan-Jin fix: batch update model card and bugs fixes (aws#712) @Zhenshan-Jin @judyheflin documentation: Amazon SageMaker Model Cards Python SDK documentation (aws#716)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
add notebook test to ci builds
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.