Skip to content

Commit

Permalink
Merge pull request #318 from matchav/retryStormFix
Browse files Browse the repository at this point in the history
KPL goes into a continous retry storm if the stream is deleted and re-created
  • Loading branch information
isurues authored Dec 10, 2020
2 parents ac4d2c8 + 2928503 commit 1d2f475
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions aws/kinesis/core/retrier.cc
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,7 @@ bool Retrier::succeed_if_correct_shard(const std::shared_ptr<UserRecord>& ur,
*ur->predicted_shard() != actual_shard) {
//We should call invalidate only if:
// 1. If we are told to invalidate on incorrect shard.
// 2. The actual destination shard is newer than the predicted shard.
if (should_invalidate_on_incorrect_shard && actual_shard > *ur->predicted_shard()) {
if (should_invalidate_on_incorrect_shard) {
LOG(warning) << "Record went to shard " << shard_id << " instead of the "
<< "predicted shard " << *ur->predicted_shard() << "; this "
<< "usually means the sharp map has changed.";
Expand Down

0 comments on commit 1d2f475

Please sign in to comment.