KPL goes into a continous retry storm if the stream is deleted and re-created #318
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
The Issue is that when a customer deletes a stream after scaling the stream for multiple times and then creates the stream with same number of shards. The KPL producer is going into continuous retry storm with error "Wrong Shard ErrorMessages: [Record did not end up in expected shard ... " but no "Record went to shard x instead of shard y.." log message.
This means, KPL has never tried to update the shard map, which is done at line 208 in retrier.cc file.
This is a bug where KPL assumes that a record can go into a different shard only when the same stream has scaled and then updates the shard Map. Hence removing this check ("The actual destination shard is newer than the predicted shard.")
Description of changes:
Hence removing the extra check "The actual destination shard is newer than the predicted shard." to update shard map. Hence the shard map will be updated every time there is invalidate on incorrect shard.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.