Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android: Fix pause emulator button crashes #382

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

kleidis
Copy link
Contributor

@kleidis kleidis commented Aug 21, 2024

This fixes the crash when passing and unpausing the emulator

It actually checks if s_surf is not None before releasing it, which I assume was the reason it even crashed

Closes #110

@OpenSauce04
Copy link
Member

Is this not from mandarine3ds/mandarine@a4ed30f?

@kleidis
Copy link
Contributor Author

kleidis commented Aug 21, 2024

Is this not from mandarine3ds/mandarine@a4ed30f?

I shared the code with him, and he took without author

As a screenshot*

@OpenSauce04
Copy link
Member

OpenSauce04 commented Aug 21, 2024

Is this not from mandarine3ds/mandarine@a4ed30f?

I shared the code with him, and he took without author

As a screenshot*

🙄

@OpenSauce04 OpenSauce04 added this to the 2118 milestone Aug 21, 2024
@OpenSauce04 OpenSauce04 self-requested a review August 21, 2024 19:27
@OpenSauce04 OpenSauce04 added the bug Something isn't working label Aug 21, 2024
Copy link
Member

@OpenSauce04 OpenSauce04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue on my end, thanks for your contribution!

@OpenSauce04 OpenSauce04 merged commit 14d0bb5 into azahar-emu:master Aug 21, 2024
12 checks passed
@kleidis kleidis deleted the puase-fix branch October 14, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App crashes after pausing emulation
2 participants