Add England, Wales, Scotland, Northern Ireland #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c960657
force-pushed
the
united-kingdom
branch
from
c1b5f07 to
77f7d12
Compare
stelgenhof
reviewed
Sep 11, 2019
stelgenhof
reviewed
Sep 11, 2019
|
Hi @c960657 Cheers! Sacha |
|
I merged the It's fixed now :-) |
stelgenhof
approved these changes
Sep 19, 2019
stelgenhof
reviewed
Sep 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public holidays are defined differently in England, Wales, Northern Ireland and particularly Scotland.
I have tried to implement providers for each of these countries based on Wikipedia (UK and Scotland), official sources (1, 2, 3), newspaper articles (4, 5) and other online sources (6, 7).
The providers for England and Wales are identical to the existing United Kingdom provider, including the unit tests. The provider for Northern Ireland is nearly identical except that it adds to holidays. The provider for Scotland is completely different (it does not call
parent::initialize().Northern Ireland did not exist as a country prior to 1921 (neither did the Republic of Ireland), but I haven't added special handling of this. I assume that the territory that is currently Northern Ireland followed the same rules as England and Wales prior to then.
Like the United Kingdom provider, these providers miss translations for substitute holidays. This issue has been addressed in PR #162.