Add SubstituteHoliday #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c960657
force-pushed
the
substitute-holiday
branch
from
86e151a to
e91d3d4
Compare
c960657
force-pushed
the
substitute-holiday
branch
from
dccaba7 to
a9003df
Compare
stelgenhof
reviewed
Sep 9, 2019
stelgenhof
reviewed
Sep 9, 2019
stelgenhof
approved these changes
Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that there is no translation for
substituteHoliday:secondChristmasDayin theUnitedKingdomprovider. I realised that providing translations for substitute holidays is cumbersome, especially when using global translations.With this PR, substitute holidays are promoted into a first-class citizen with the
SubstituteHolidayclass. It references the substituted holiday and can inherit the translations from that with an “observed” suffix appended, if the substitute holiday itself does not have an original name.The idea of using
{0}as a placeholder is inherited from CLDR (see e.g. https://raw.githubusercontent.com/unicode-org/cldr/master/common/main/nl.xml).