Locale override for getName() #184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c960657
force-pushed
the
locale-override
branch
from
80a1ce6 to
7be398e
Compare
|
One further possible feature would be allowing the user override the “default fallback locale chain”, e.g. by passing an array of locales instead of just a string. E.g. |
|
I have created a alternative PR that implements the suggestion in my latest comment: #195. |
|
This pull request has been open 30 days with no activity. Please remove the stale label or comment, or this will be closed in 5 days |
|
@c960657 I have reviewed and merged your other PR. I guess we can close this one, right? |
|
Yes, this PR is no longer relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes you need multiple translations for the same holiday.
Pre v2.2.0 you could easily access all translations in
$holiday->translations. With the introduction of locale fallback in #176, things got more complicated, especially with substitute holidays (introduced in #162), so accessing thetranslationsproperty is difficult.I suggest adding an optional
$localeparameter to$holiday->getName().This fixes #181.
This suggestion is a subset of what was proposed in #123. This PR does not include the default locale part, only the locale override.