Fix TLS errors preventing Redis connections in production #3899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioredis 4.14.0 introduced an issue where custom TLS options are no longer honored. I reported it here: redis/ioredis#947 For now let's downgrade to the latest working version, which I've confirmed working via the script (checked in).
paulmelnikow
added
the
operations
|
calebcartwright
approved these changes
Aug 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ioredis 4.14.0 introduced an issue where custom TLS options are no longer honored. I reported it here: redis/ioredis#947
This has been preventing the server from using GitHub tokens, however I'm not sure whether or not this has been causing noticeable issues.
For now let's downgrade to the latest working version, which I've confirmed working via the script (checked in).