upgrade: electron-builder to v19.9.1
#1548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhermsmeier
approved these changes
Jun 26, 2017
jviotti
force-pushed
the
upgrade-electron-builder
branch
4 times, most recently
from
66c442e to
5f2f3e7
Compare
jviotti
changed the title
electron-builder to v19.8.0electron-builder to v19.9.1
jviotti
force-pushed
the
upgrade-electron-builder
branch
from
5f2f3e7 to
541ee65
Compare
|
Failing on Travis with |
|
I'm trying to debug the issue here: electron-userland/electron-builder#1784 |
jviotti
force-pushed
the
upgrade-electron-builder
branch
from
541ee65 to
0aaa230
Compare
|
OK, it was totally our fault. I updated the Makefile, and now everything should work. |
jviotti
force-pushed
the
upgrade-electron-builder
branch
from
0aaa230 to
a525801
Compare
- Exclude *.dll/*.exe files from the asar in non-Windows operating systems (from 19.8.0) - Correctly parse boolean flags in `--extraMetadata` (in v19.9.0) See: https://github.com/electron-userland/electron-builder/releases/tag/v19.9.1 Change-Type: patch Signed-off-by: Juan Cruz Viotti <[email protected]>
jviotti
force-pushed
the
upgrade-electron-builder
branch
from
a525801 to
d94b076
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exclude *.dll/*.exe files from the asar in non-Windows operating
systems (from 19.8.0)
Correctly parse boolean flags in
--extraMetadata(in v19.9.0)See: https://github.com/electron-userland/electron-builder/releases/tag/v19.9.1
Change-Type: patch
Signed-off-by: Juan Cruz Viotti [email protected]