-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2201.9.x] Introduce transactionAutoCommitTimeout
and transactionCleanupTimeout
configuration values for transactions
#42963
[2201.9.x] Introduce transactionAutoCommitTimeout
and transactionCleanupTimeout
configuration values for transactions
#42963
Conversation
This commit introduces two new configurations values for transactions, `transactionAutoCommitTimeout` and `transactionCleanupTimeout`
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2201.9.x #42963 +/- ##
==============================================
- Coverage 76.87% 76.86% -0.02%
- Complexity 54083 54118 +35
==============================================
Files 2925 2925
Lines 204270 204397 +127
Branches 26660 26687 +27
==============================================
+ Hits 157039 157108 +69
- Misses 38660 38717 +57
- Partials 8571 8572 +1 ☔ View full report in Codecov by Sentry. |
6e22127
to
f5cc07d
Compare
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved based on reviews done already to 2201.8.x. Also tried using the new configurable variables.
Purpose
Introduces new configurations to prevent premature commits of long-running transactions before reaching the commit phase.
Related #42922
Approach
This PR introduces two new configurations values for transactions,
transactionAutoCommitTimeout
andtransactionCleanupTimeout
.ballerinai-transaction PR: ballerina-platform/module-ballerinai-transaction#549
Samples
You can change the
Config.toml
with these two new configs as below.Remarks
ballerinai-transaction PR: ballerina-platform/module-ballerinai-transaction#549
Check List