Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make transaction cleanup timeouts configurable #549

Conversation

dsplayerX
Copy link
Contributor

@dsplayerX dsplayerX commented Jun 18, 2024

Purpose

Allow configuring transaction cleanup timeouts for long running transactions.

Related to ballerina-platform/ballerina-lang#42922
Depends on ballerina-platform/ballerina-lang#42940

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Uses two new configurations transactionAutoCommitTimeout and transactionCleanupTimeout values for auto committing timeout for long running transactions and cleaning up dead transactions.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to [email protected] and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

  • Unit tests

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Security checks

Samples

Provide high-level details about the samples related to this feature

Related PRs

Lang PR: ballerina-platform/ballerina-lang#42940

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

@dsplayerX dsplayerX marked this pull request as ready for review June 18, 2024 09:45
@dsplayerX dsplayerX changed the title [WIP] Fix 42922 long running trans [WIP] Make transaction cleanup timeouts configurable Jun 18, 2024
@dsplayerX dsplayerX changed the title [WIP] Make transaction cleanup timeouts configurable Make transaction cleanup timeouts configurable Jun 18, 2024
gimantha
gimantha previously approved these changes Jun 21, 2024
Copy link

github-actions bot commented Jul 6, 2024

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Jul 6, 2024
Copy link

github-actions bot commented Jul 9, 2024

Closed PR due to inactivity for more than 18 days.

@github-actions github-actions bot closed this Jul 9, 2024
@gimantha gimantha removed the Stale label Jul 10, 2024
@gimantha gimantha reopened this Jul 10, 2024
Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Jul 25, 2024
@gimantha gimantha removed the Stale label Jul 29, 2024
@MaryamZi MaryamZi changed the base branch from master to 1.9.x August 8, 2024 08:22
@MaryamZi MaryamZi closed this Aug 8, 2024
@MaryamZi MaryamZi reopened this Aug 8, 2024
@MaryamZi MaryamZi changed the base branch from 1.9.x to master August 8, 2024 11:50
@MaryamZi MaryamZi dismissed gimantha’s stale review August 8, 2024 11:50

The base branch was changed.

Copy link

codecov bot commented Aug 10, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 55.76%. Comparing base (89b8ad0) to head (634464d).

Files Patch % Lines
transaction-ballerina/commons.bal 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #549      +/-   ##
============================================
+ Coverage     55.48%   55.76%   +0.27%     
  Complexity       16       16              
============================================
  Files            21       21              
  Lines           647      651       +4     
  Branches        320      322       +2     
============================================
+ Hits            359      363       +4     
  Misses          287      287              
  Partials          1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MaryamZi
Copy link
Member

Introduced in #562.

@MaryamZi MaryamZi closed this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants