add support for building with boringcrypto #3391
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
reviewed
Dec 12, 2022
| @@ -130,7 +131,7 @@ func TestLib(t *testing.T) { | |||
| } | |||
|
|
|||
| func TestTool(t *testing.T) { | |||
| err := exec.Command("Tool").Run() | |||
| err := exec.Command("." + string(filepath.Separator) + "Tool").Run() | |||
There was a problem hiding this comment.
Is this change due to the recent security fix?
There was a problem hiding this comment.
I think this was changed when 1.19 was released: https://tip.golang.org/doc/go1.19#os-exec-path
There was a problem hiding this comment.
done, ran into some difficulties so I had to force push
fmeum
reviewed
Dec 13, 2022
WORKSPACE
Outdated
| @@ -6,7 +6,9 @@ load("@io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_depe | |||
|
|
|||
| go_rules_dependencies() | |||
|
|
|||
| go_register_toolchains(version = "1.18.3") | |||
| go_register_toolchains( | |||
| version = "1.19.3", | |||
matloob
force-pushed
the
boringcrypto
branch
from
4e3df2c to
7cecc7d
Compare
Adds an option to go_register_toolchains and the various go_*_sdk functions to specify boringcrypto = True. Doing so builds the standard library and all library/binary packages using the GOEXPERIMENT=boringcrypto environment variable setting, which switches out the crypto implementation for boringcrypto on Go 1.19+.
matloob
force-pushed
the
boringcrypto
branch
from
7cecc7d to
6d6b607
Compare
|
I think something got messed up here. I tried making new PRs from other branches, and they are also failing for the same reason. I suspect it has to do with the force-push... |
fmeum
force-pushed
the
boringcrypto
branch
2 times, most recently
from
a38b672 to
ef5197d
Compare
matloob
force-pushed
the
boringcrypto
branch
from
ef5197d to
09ebad6
Compare
|
Abandoned in favor of #3398. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to go_register_toolchains and the various go_*_sdk functions to specify boringcrypto = True. Doing so builds the standard library and all library/binary packages using the GOEXPERIMENT=boringcrypto environment variable setting, which switches out the crypto implementation for boringcrypto on Go 1.19+.
What type of PR is this?
What does this PR do? Why is it needed?
It adds support for building with boringcrypto, which was added in Go 1.19.
Which issues(s) does this PR fix?
Fixes #
Other notes for review