Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incompatible_disable_legacy_proto_provider: Remove legacy dep.proto. access to the proto provider #7152

Closed
lberki opened this issue Jan 17, 2019 · 12 comments
Closed

incompatible_disable_legacy_proto_provider: Remove legacy dep.proto. access to the proto provider #7152

lberki opened this issue Jan 17, 2019 · 12 comments
Assignees
@lberki
Labels
incompatible-change Incompatible/breaking change P1 I'll work on this now. (Assignee required) team-Rules-Server Issues for serverside rules included with Bazel

Comments

@lberki
Copy link
Contributor

lberki commented Jan 17, 2019

We are migrating off of legacy providers that are addressed by name to providers addressed: https://bazel.build/designs/skylark/declared-providers.html

This bug is for migrating the provider containing information about .proto files. The following changes are required in Starlark sources:

  • Change the way the provider is accessed from ctx.attr.dep.proto. to ctx.attr.dep[ProtoInfo]
  • Change the way the presence of provider is checked from hasattr(dep, "proto") to ProtoInfo in dep
  • Change the way a rule requires a provider from providers = [["​proto"]] to providers = [[ProtoInfo]]
@lberki lberki added team-Rules-Server Issues for serverside rules included with Bazel incompatible-change Incompatible/breaking change migration-ready labels Jan 17, 2019
@lberki lberki mentioned this issue Jan 17, 2019
Closed
@philwo
Copy link
Member

philwo commented Feb 6, 2019

This flag was not flipped in time for the Bazel 0.23.0 release and will thus be postponed to Bazel 0.24.0.

@drigz
Copy link
Contributor

drigz commented Feb 28, 2019

ProtoInfo was introduced in 0.22.0. Is there a way for code to be compatible with both 0.21.0 and 0.24.0 Bazel versions?

@drigz drigz mentioned this issue Feb 28, 2019
Closed
@laurentlb
Copy link
Contributor

As it would break many projects on the CI and we plan to cut Bazel 0.24 tomorrow, the flag flip will be postponed.

@katre
Copy link
Member

katre commented Mar 1, 2019

This issue was tagged as "breaking-change-0.24" but does not appear ready to be flipped in the 0.24.0 release. If this is incorrect please comment on that issue and discuss with me.

drigz added a commit to drigz/grpc-gateway that referenced this issue Mar 4, 2019
@drigz
bazel: Use new ProtoInfo provider
88c617b 
The old `.proto` provider will be removed in a future Bazel release:
bazelbuild/bazel#7152
drigz added a commit to drigz/grpc-gateway that referenced this issue Mar 4, 2019
@drigz
bazel: Use new ProtoInfo provider
a552b5b 
The old `.proto` provider will be removed in a future Bazel release:
bazelbuild/bazel#7152

The Bazel build now requires Bazel 0.22.0 or newer.
@drigz drigz mentioned this issue Mar 4, 2019
Merged
achew22 pushed a commit to grpc-ecosystem/grpc-gateway that referenced this issue Mar 4, 2019
@drigz @achew22
bazel: Use new ProtoInfo provider
87b57f5 
The old `.proto` provider will be removed in a future Bazel release:
bazelbuild/bazel#7152

The Bazel build now requires Bazel 0.22.0 or newer.
mfarrugi added a commit to bazelbuild/rules_rust that referenced this issue Mar 30, 2019
@mfarrugi
Use ProtoInfo instead of legacy .proto attr
86cde7d 
bazelbuild/bazel#7152
@mfarrugi mfarrugi mentioned this issue Mar 30, 2019
Merged
@hlopko
Copy link
Member

hlopko commented Jun 7, 2019

And it also wasn't flipped for 0.26 or 0.27, so 1.0 it is :)

@hlopko hlopko mentioned this issue Jun 20, 2019
Closed
hlopko added a commit to hlopko/protobuf that referenced this issue Jun 20, 2019
@hlopko
Migrate protobuf for bazelbuild/bazel#7152
df24c78 
This PR migrates protobuf.bzl for Bazel's incompatible change bazelbuild/bazel#7152.
This was referenced Jun 20, 2019
Closed
Merged
hlopko added a commit to hlopko/protobuf that referenced this issue Jun 20, 2019
@hlopko
Migrate protobuf for bazelbuild/bazel#7152
bfb1538 
This PR migrates protobuf.bzl for Bazel's incompatible change bazelbuild/bazel#7152.
@hlopko hlopko mentioned this issue Jun 20, 2019
Closed
@lberki
Copy link
Contributor Author

lberki commented Jul 19, 2019

Fix for rules_rust is at bazelbuild/rules_rust#242

@lberki
Copy link
Contributor Author

lberki commented Jul 19, 2019 •
edited
Loading

Fix for Bazel is at #8938

@lberki lberki mentioned this issue Jul 19, 2019
Merged
12 tasks
@lberki
Copy link
Contributor Author

lberki commented Jul 19, 2019

Fix for ts_proto_library (and thus Bazel Codelabs) is at bazel-contrib/rules_nodejs#925 .

@lberki lberki added the P1 I'll work on this now. (Assignee required) label Jul 25, 2019
@lberki
Copy link
Contributor Author

lberki commented Aug 7, 2019

Pull request to fix Envoy: envoyproxy/envoy#7850

@scentini scentini removed the untriaged label Aug 7, 2019
@lberki
Copy link
Contributor Author

lberki commented Aug 7, 2019

Bug for rules_nodejs: bazel-contrib/rules_nodejs#979

@lberki
Copy link
Contributor Author

lberki commented Aug 7, 2019

Codelabs issue: bazelbuild/codelabs#11

gertvdijk added a commit to TulipSolutions/tecl that referenced this issue Sep 12, 2019
@gertvdijk
Bazel rules: Adjust accessing ProtoInfo of dependencies
0543d08 
To be compatible with Bazel 0.29+. See also:
bazelbuild/bazel#7152

Change-Id: Idd53f148aadc44c727966e8910f2776704a018a6
GitOrigin-RevId: 6922a516dd7c4a9c2cc8a981f2e4b9f74488ed78
@asraa asraa mentioned this issue Oct 21, 2019
Merged
Yannic added a commit to Yannic/bazel that referenced this issue Jan 15, 2020
@Yannic
Remove unused LEGACY_SKYLARK_NAME from ProtoInfo
8470f00 
The legacy `.proto` provider has been removed in bazelbuild#7152.
@Yannic Yannic mentioned this issue Jan 15, 2020
Closed
bazel-io pushed a commit that referenced this issue Feb 4, 2020
@Yannic @copybara-github
Remove unused LEGACY_SKYLARK_NAME from ProtoInfo
1a5ec8b 
The legacy `.proto` provider has been removed in #7152.

Closes #10591.

PiperOrigin-RevId: 293101268
adasari pushed a commit to adasari/grpc-gateway that referenced this issue Apr 9, 2020
@drigz @achew22
bazel: Use new ProtoInfo provider
ee8c991 
The old `.proto` provider will be removed in a future Bazel release:
bazelbuild/bazel#7152

The Bazel build now requires Bazel 0.22.0 or newer.
luca-digrazia pushed a commit to luca-digrazia/DatasetCommitsDiffSearch that referenced this issue Sep 4, 2022
Remove unused LEGACY_SKYLARK_NAME from ProtoInfo
64db262 
    The legacy `.proto` provider has been removed in bazelbuild/bazel#7152.

    Closes #10591.

    PiperOrigin-RevId: 293101268
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lberki lberki

Labels
incompatible-change Incompatible/breaking change P1 I'll work on this now. (Assignee required) team-Rules-Server Issues for serverside rules included with Bazel
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@katre @laurentlb @philwo @drigz @hlopko @lberki @meteorcloudy @dslomov @dkelmer @scentini