Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Breakage with breaks with the Bazel flag --incompatible_disable_legacy_proto_provider, to be flipped in Bazel 1.0 #11

Open
lberki opened this issue Aug 7, 2019 · 1 comment

Comments

@lberki
Copy link

lberki commented Aug 7, 2019

The breakage looks like this:

ERROR: /var/lib/buildkite-agent/builds/bk-docker-knlk/bazel-downstream-projects/codelabs/proto/logger/BUILD:31:1: in ts_proto_library rule //proto/logger:logger_ts_proto:
--
  | Traceback (most recent call last):
  | File "/var/lib/buildkite-agent/builds/bk-docker-knlk/bazel-downstream-projects/codelabs/proto/logger/BUILD", line 31
  | ts_proto_library(name = 'logger_ts_proto')
  | File "/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/a3cacd8feec2143defdbcf39e90c9abd/external/npm_bazel_typescript/internal/protobufjs/ts_proto_library.bzl", line 74, in _ts_proto_library
  | fail(("ts_proto_library dep %s must b...))
  | ts_proto_library dep //proto/logger:logger_proto must be a proto_library rule

Which indicates that it uses a version of ts_proto_library which does not contain bazel-contrib/rules_nodejs#925 .

@aiuto
Copy link
Contributor

aiuto commented Apr 7, 2020

I have no idea why I assigned this to myself. It must have been a drive by accidental click.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants