Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Update all the workspace dependencies #12

Merged
merged 4 commits into from
Aug 13, 2019
Merged

Update all the workspace dependencies #12

merged 4 commits into from
Aug 13, 2019

Conversation

aiuto
Copy link
Contributor

@aiuto aiuto commented Aug 12, 2019 •
edited
Loading

Everything was out of date.
This change mostly does nothing but use the latest of everything.
It also adds the typescript build file to generate_build_files.

Tested by

  • ./generate_build_files.sh
  • bazel build ...
  • bazel test ...
  • Follow the instructions at the end of README to run the servers
    • see that it works
  • build again with --incompatible_disable_legacy_proto_provider

FWIW, this mechanism for creating the WORKSPACE and BUILD files with simple scripts is unsustainable. After you get dependencies updated, you have to go back and comment out just the right lines in various places. If we do more of these, it needs a redesign.

aiuto added 4 commits August 12, 2019 15:04
@aiuto
update everything
00c3e8b
@aiuto
Update codelab deps
dd12af6
@aiuto
Try to do a sane update.
5e3c53f
@aiuto
Split generate_workspace out of generate_build_files.sh so that
90229c0 
it is easier to test workspace updates without whacking the
build files. generate_build_files still does the WORKSPACE
generation, so we do not have to change CI.
@aiuto aiuto requested review from dkelmer and rupertks as code owners August 12, 2019 21:03
@aiuto aiuto requested a review from lberki August 12, 2019 21:03
@aiuto
Copy link
Contributor Author

aiuto commented Aug 12, 2019

Fixes #11

@lberki
Copy link

lberki commented Aug 13, 2019 •
edited
Loading

This fixes the issue? I thought that since the error comes from the @npm_bazel_typescript repository, the fix requires first propagating a change to NPM somehow.

Did I misread the error message or do that .bzl files that get fetched from NPM get updated by some non-obvious mechanism?

lberki
lberki approved these changes Aug 13, 2019
View reviewed changes
Copy link

@lberki lberki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But since "everything was out of date", this is an improvement in any case :)

rupertks
rupertks approved these changes Aug 13, 2019
View reviewed changes
Copy link
Contributor

@rupertks rupertks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aiuto
Copy link
Contributor Author

aiuto commented Aug 13, 2019

This fixes the issue? I thought that since the error comes from the @npm_bazel_typescript repository, the fix requires first propagating a change to NPM somehow.

AFAICT, this fixes the issue. bazel test ---incompatible_disable_legacy_proto_provider still works.

Did I misread the error message or do that .bzl files that get fetched from NPM get updated by some non-obvious mechanism?

They get updated in a non-obvious way. There are many changes to typescript/yarn.lock, caused by just updating a few lines in typescript/package.json. I think the biggest one was @bazel/typescript changing from 0.27.7 to 0.35.0.

@aiuto aiuto merged commit dac5675 into bazelbuild:master Aug 13, 2019
@aiuto aiuto deleted the update branch August 13, 2019 13:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rupertks rupertks rupertks approved these changes

@lberki lberki lberki approved these changes

@dkelmer dkelmer Awaiting requested review from dkelmer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aiuto @lberki @rupertks