Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(bzlmod): refactor pip_parse to make it more testable #2314

Merged
merged 48 commits into from
Oct 21, 2024
Merged

test(bzlmod): refactor pip_parse to make it more testable #2314

merged 48 commits into from
Oct 21, 2024
+1,395 −1,030

Conversation

aignas
Copy link
Collaborator

@aignas aignas commented Oct 18, 2024 •
edited
Loading

This PR introduces a new parse_modules function in the pypi/extension.bzl
code to mimic the structure of the python extension and to make it easier to
write unit tests against the extension itself. I have also written a few unit
tests to verify the generic structure.

Work towards #2268.

aignas added 20 commits October 19, 2024 11:04
@aignas
Merge branch 'main' into refactor/pip-parse-testable
d53e91b
@aignas
refactor: remove side effects in _create_whl_repos
03cc7b5
@aignas
refactor: pass get_index_urls function to _create_whl_repos
6642756
@aignas
refactor: allow passing simpleapi_download func
57aa35d
@aignas
refactor: move the group_map construction out of the
c20d69f 
_create_whl_libraries func
@aignas
refactor: flatten the whl_map
54b5627
@aignas
refactor: flatten the exposed_packages
9167b0c
@aignas
refactor: Add a helper to ensure that we don't overwrite data
db0530e
@aignas
refactor: pass the minimum set of attrs to _create_whl_repos
6a8913c
@aignas
refactor: cleanup the call to create whl_repos
a9cf358
@aignas
refactor: reduce the API surface of _create_whl_repos
91a96dc
@aignas
refactor: move the evaluate_markers_fn creation out of create_whl_repos
dbbe314
@aignas
refactor: move the creation of the libraries to a separate function
d141734
@aignas
refactor: move creation of the args to a separate function
389f3ee
@aignas
refactor: normalize the whl_name everywhere in wheel dicts to allow u…
d0330a5 
…sers pass whl_mods by any name
@aignas
inline _set_or_fail and use kwargs for whl_library_args
01134c9
@aignas
move the parsing of the requirements out
a536f04
@aignas
move the selection of algorithms out of the processing function
ed15370
@aignas
get rid of some default_value handling
cd4ad80
@aignas
create a function for default whl library args
7a97789
@aignas aignas marked this pull request as draft October 20, 2024 03:22
@aignas aignas changed the title refactor(bzlmod): refactor pip_parse to make it more testable test(bzlmod): refactor pip_parse to make it more testable Oct 21, 2024
@aignas aignas marked this pull request as ready for review October 21, 2024 00:34
@aignas aignas mentioned this pull request Oct 21, 2024
Closed
rickeylev
rickeylev approved these changes Oct 21, 2024
View reviewed changes
python/private/pypi/extension.bzl Outdated Show resolved Hide resolved
tests/pypi/extension/parse_modules_subject.bzl Outdated Show resolved Hide resolved
@aignas aignas added this pull request to the merge queue Oct 21, 2024
Merged via the queue into bazelbuild:main with commit 6d108c4 Oct 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickeylev rickeylev rickeylev approved these changes

@groodt groodt Awaiting requested review from groodt groodt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aignas @rickeylev