Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(bzlmod): refactor pip_parse to make it more testable #2314

Merged
merged 48 commits into from
Oct 21, 2024
Merged

test(bzlmod): refactor pip_parse to make it more testable #2314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
4d79c89
refactor: introduce a new private function to parse module_ctx
aignas Oct 18, 2024
7f8f726
refactor: move override processing to there
aignas Oct 18, 2024
1d84239
refactor: move pip_parse state to parse_modules
aignas Oct 18, 2024
0ba818a
refactor: move whl_library construction to parse_modules
aignas Oct 18, 2024
ea5d67e
refactor: move whl_library construction out of parse_modules
aignas Oct 18, 2024
cd53b6d
cleanup
aignas Oct 18, 2024
ef1993a
cleanup
aignas Oct 18, 2024
570e20b
cleanup
aignas Oct 18, 2024
d53e91b
Merge branch 'main' into refactor/pip-parse-testable
aignas Oct 19, 2024
03cc7b5
refactor: remove side effects in _create_whl_repos
aignas Oct 19, 2024
6642756
refactor: pass get_index_urls function to _create_whl_repos
aignas Oct 19, 2024
57aa35d
refactor: allow passing simpleapi_download func
aignas Oct 19, 2024
c20d69f
refactor: move the group_map construction out of the
aignas Oct 19, 2024
54b5627
refactor: flatten the whl_map
aignas Oct 19, 2024
9167b0c
refactor: flatten the exposed_packages
aignas Oct 19, 2024
db0530e
refactor: Add a helper to ensure that we don't overwrite data
aignas Oct 19, 2024
6a8913c
refactor: pass the minimum set of attrs to _create_whl_repos
aignas Oct 19, 2024
a9cf358
refactor: cleanup the call to create whl_repos
aignas Oct 19, 2024
91a96dc
refactor: reduce the API surface of _create_whl_repos
aignas Oct 19, 2024
dbbe314
refactor: move the evaluate_markers_fn creation out of create_whl_repos
aignas Oct 19, 2024
d141734
refactor: move the creation of the libraries to a separate function
aignas Oct 19, 2024
389f3ee
refactor: move creation of the args to a separate function
aignas Oct 19, 2024
d0330a5
refactor: normalize the whl_name everywhere in wheel dicts to allow u…
aignas Oct 20, 2024
01134c9
inline _set_or_fail and use kwargs for whl_library_args
aignas Oct 20, 2024
a536f04
move the parsing of the requirements out
aignas Oct 20, 2024
ed15370
move the selection of algorithms out of the processing function
aignas Oct 20, 2024
cd4ad80
get rid of some default_value handling
aignas Oct 20, 2024
7a97789
create a function for default whl library args
aignas Oct 20, 2024
1b16afe
move the common whl library arg construction to a different place
aignas Oct 20, 2024
448ac3f
cleanup the default arg building
aignas Oct 20, 2024
a7c7426
get rid of pip_attr usage more
aignas Oct 20, 2024
5cfea2b
TODO: pass the extra_pip_args correctly
aignas Oct 20, 2024
18c5057
test: add a first unit test
aignas Oct 20, 2024
02aabaf
wip
aignas Oct 20, 2024
1f0a1a7
revert refactors and maintain the test
aignas Oct 20, 2024
a628782
implement a custom subject
aignas Oct 20, 2024
aebeed0
finish cleaning up the args
aignas Oct 20, 2024
3d7c677
fixup! finish cleaning up the args
aignas Oct 20, 2024
dfb24be
cleanup
aignas Oct 20, 2024
dab3d0f
test: finish the test with get_index_url
aignas Oct 21, 2024
8eded81
revert an unnecessary change
aignas Oct 21, 2024
ae9d120
comment: use env.expect.that_struct
aignas Oct 21, 2024
89f5534
comment: add docstring
aignas Oct 21, 2024
e878dd7
improve: remove all side effects from _create_whl_repos and sort output
aignas Oct 21, 2024
502cbf2
Merge branch 'main' into refactor/pip-parse-testable
aignas Oct 21, 2024
31355cd
chore: pre-commit
aignas Oct 21, 2024
da32a64
test fixup
aignas Oct 21, 2024
45fb65d
fixup
aignas Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading