Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support artifact dependencies in crate.spec #2229

Merged
merged 4 commits into from
Oct 31, 2023

Conversation

dtolnay
Copy link
Contributor

@dtolnay dtolnay commented Oct 31, 2023

Followup to #2226. That PR made bindeps work for crates repositories that use manifests.

manifests = ["//cargo_bindeps:Cargo.toml"],

This PR makes it work for crates repositories that use packages.

"cxxbridge-cmd": crate.spec(
artifact = "bin",
version = "1.0.109",
),

Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@UebelAndre UebelAndre merged commit 841a733 into bazelbuild:main Oct 31, 2023
@dtolnay dtolnay deleted the bindepspec branch October 31, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants