Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert cxxbridge-cmd dependency to bindep #2230

Closed
wants to merge 3 commits into from

Conversation

dtolnay
Copy link
Contributor

@dtolnay dtolnay commented Oct 31, 2023

This is how I tested #2229.

I am not sure whether we want this in rules_rust yet because the existing @cxxbridge-cmd serves as a useful example for users to copy into their own workspaces, and not all of those users use nightly. If we are open to using -Zbindeps unconditionally on all toolchains (via RUSTC_BOOTSTRAP=1) then I'll finish this up, otherwise defer to after artifact dependencies is stable.

Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together!

I think in the short term we should probably block on stabilisation of bindeps, but if that looks like it's going to take forever we can reconsider an approach.

Ideally we would not add RUSTC_BOOTSTRAP=1 in rules_rust :)

@dtolnay
Copy link
Contributor Author

dtolnay commented Oct 31, 2023

Okay! That sounds good to me.

@dtolnay dtolnay closed this Oct 31, 2023
@dtolnay dtolnay deleted the cxxbridge branch October 31, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants