Convert cxxbridge-cmd dependency to bindep #2230
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is how I tested #2229.
I am not sure whether we want this in rules_rust yet because the existing
@cxxbridge-cmd
serves as a useful example for users to copy into their own workspaces, and not all of those users use nightly. If we are open to using-Zbindeps
unconditionally on all toolchains (viaRUSTC_BOOTSTRAP=1
) then I'll finish this up, otherwise defer to after artifact dependencies is stable.