Upgrade scala 2.12.x and 2.13.x versions #1515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scoquelin
commented
Sep 28, 2023
| class KKTImpl extends HKT[Either[String, *]] |
There was a problem hiding this comment.
This commit has broken compilation for this file (since Scala 2.12.16) as ? was repurposed for Scala 3. Found out that replacing ? by * was the simplest workaround to avoid bringing -Xsource:3 (and more) compiler flags just yet.
See https://docs.scala-lang.org/scala3/guides/migration/plugin-kind-projector.html for more info... this one took me a bit to figure out 😅
scoquelin
commented
Sep 28, 2023
Comment on lines
+12
to
+20
| BRDA:5,0,0,1 | ||
| BRDA:5,0,1,0 | ||
| BRF:2 | ||
| BRH:1 | ||
| DA:3,1 | ||
| DA:5,1 | ||
| DA:6,1 | ||
| DA:6,0 | ||
| DA:7,1 | ||
| LH:4 | ||
| LH:3 |
There was a problem hiding this comment.
Not sure where the changes in the coverage files comes from but after generating and inspecting coverage reports new changes are definitely more accurate as the failure case for A1.a1(false) was actually not covered by the test and is now depicted as a missing branch in the report.
Before :
After :
scoquelin
force-pushed
the
upgrade-scala-versions
branch
from
dabd033 to
cb25892
Compare
liucijus
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bumping supported Scala 2.12 and 2.13 minor versions
Found a compilation issue related to
kind_projectorso updated to latest artifacts as well for all Scala major versions.Motivation
I wanted to level up minor Scala versions before trying to tackle #1514 that has breaking changes related to Scala
2.13.12