Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade scala 2.12.x and 2.13.x versions #1515

Merged
merged 4 commits into from
Oct 2, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix expected-coverage.dat files
scoquelin committed Sep 28, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit cb25892155d0703b73f0e5028228ab226fde2f47
8 changes: 4 additions & 4 deletions test/coverage_filename_encoding/expected-coverage.dat
Original file line number Diff line number Diff line change
@@ -9,14 +9,14 @@ FNDA:1,coverage_filename_encoding/A1$::a1 (Z)Ljava/lang/String;
FNDA:0,coverage_filename_encoding/A1::a1 (Z)Ljava/lang/String;
FNF:4
FNH:3
BRDA:5,0,0,0
BRDA:5,0,1,1
BRDA:5,0,0,1
BRDA:5,0,1,0
BRF:2
BRH:1
DA:3,1
DA:5,1
DA:6,1
DA:6,0
DA:7,1
LH:4
LH:3
LF:4
end_of_record
8 changes: 4 additions & 4 deletions test/coverage_scalatest/expected-coverage.dat
Original file line number Diff line number Diff line change
@@ -9,15 +9,15 @@ FNDA:1,coverage_scalatest/A1$::a1 (Z)Lcoverage_scalatest/B1$;
FNDA:0,coverage_scalatest/A1::a1 (Z)Lcoverage_scalatest/B1$;
FNF:4
FNH:3
BRDA:5,0,0,0
BRDA:5,0,1,1
BRDA:5,0,0,1
BRDA:5,0,1,0
BRF:2
BRH:1
DA:3,1
DA:5,1
DA:6,1
DA:6,0
DA:7,1
LH:4
LH:3
Comment on lines +12 to +20
Copy link
Contributor Author

@scoquelin scoquelin Sep 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure where the changes in the coverage files comes from but after generating and inspecting coverage reports new changes are definitely more accurate as the failure case for A1.a1(false) was actually not covered by the test and is now depicted as a missing branch in the report.

Before :

expected-coverage-scalatest

After :

actual-coverage-scalatest

LF:4
end_of_record
SF:test/coverage_scalatest/A2.scala
8 changes: 4 additions & 4 deletions test/coverage_specs2_with_junit/expected-coverage.dat
Original file line number Diff line number Diff line change
@@ -9,15 +9,15 @@ FNDA:1,coverage_specs2_with_junit/A1$::a1 (Z)Lcoverage_specs2_with_junit/B1$;
FNDA:0,coverage_specs2_with_junit/A1::a1 (Z)Lcoverage_specs2_with_junit/B1$;
FNF:4
FNH:3
BRDA:5,0,0,0
BRDA:5,0,1,1
BRDA:5,0,0,1
BRDA:5,0,1,0
BRF:2
BRH:1
DA:3,1
DA:5,1
DA:6,1
DA:6,0
DA:7,1
LH:4
LH:3
LF:4
end_of_record
SF:test/coverage_specs2_with_junit/A2.scala