-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds MostRead to STY's second column #5739
Merged
Merged
Changes from 36 commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
92ffc9e
Added MostRead to STY's second column
HarveyPeachey 0f8f6d0
Merge branch 'latest' into most-read-sty-col
HarveyPeachey 5f2aa3d
Replaced maxTwoColumn boolean with new columnLayout prop
HarveyPeachey eefcb3e
Merge branch 'latest' of https://github.com/bbc/simorgh into most-rea…
HarveyPeachey 4d58637
Repositioned MostRead container in the correct position
HarveyPeachey ac4a9d5
Merge branch 'latest' into most-read-sty-col
HarveyPeachey 6f7def8
Merge branch 'latest' into most-read-sty-col
FK78 3fbc46b
Merge branch 'latest' of github.com:bbc/simorgh into most-read-sty-col
a575750
Merge branch 'most-read-sty-col' of github.com:bbc/simorgh into most-…
1b62c95
chore: bump psammead-grid
5bebdc3
Merge of latest
HarveyPeachey 5e56ed9
Updated snapshots
HarveyPeachey 4ad8858
Bumped psammead-most-read
HarveyPeachey 91bfdf0
Removed component wrapper background for UX requirements
HarveyPeachey 0679fdf
Merge branch 'latest' into most-read-sty-col
HarveyPeachey 618627c
Merge branch 'latest' into most-read-sty-col
FK78 89154a1
Merge branch 'latest' into most-read-sty-col
EinsteinNjoroge a0264bf
Merge branch 'latest' into most-read-sty-col
HarveyPeachey 7d09539
Merge branch 'latest' of https://github.com/bbc/simorgh into most-rea…
HarveyPeachey 04f8177
Bump most read to 4.0.1
HarveyPeachey f732ee1
Merge branch 'latest' into most-read-sty-col
EinsteinNjoroge d8a31de
Added most-read endpount overide for storybook, added parentColumn to…
HarveyPeachey d728139
Merge branch 'latest' of https://github.com/bbc/simorgh into most-rea…
HarveyPeachey b1d4044
Updated snapshots
HarveyPeachey 95d283c
Merge branch 'most-read-sty-col' of https://github.com/bbc/simorgh in…
HarveyPeachey 8b396f9
Merge branch 'latest' of https://github.com/bbc/simorgh into most-rea…
HarveyPeachey 70e79c0
Passed correct layout prop
HarveyPeachey 6c275b4
Merge branch 'latest' into most-read-sty-col
HarveyPeachey 3439509
Merge branch 'latest' into most-read-sty-col
FK78 cd5ba10
Merge https://github.com/bbc/simorgh into most-read-sty-col
HarveyPeachey 2c5fb5c
Updated psammead-most-read to 4.0.2
HarveyPeachey 172df91
Merge branch 'most-read-sty-col' of https://github.com/bbc/simorgh in…
HarveyPeachey 22a2107
Merge branch 'latest' into most-read-sty-col
thekp 773bc65
Added and updated story book
HarveyPeachey 4da8300
Merge branch 'latest' into most-read-sty-col
HarveyPeachey 8242f1d
Merge branch 'most-read-sty-col' of https://github.com/bbc/simorgh in…
HarveyPeachey d9b4a30
Merge branch 'latest' into most-read-sty-col
HarveyPeachey 012aa65
Merge branch 'latest' into most-read-sty-col
ca49741
Merge branch 'latest' into most-read-sty-col
HarveyPeachey b1369ce
Merge latest
HarveyPeachey 45d394e
Merge branch 'latest' of https://github.com/bbc/simorgh into most-rea…
HarveyPeachey 7b98fe2
Merge branch 'latest' into most-read-sty-col
HarveyPeachey 87d1c42
Merge branch 'latest' of https://github.com/bbc/simorgh into most-rea…
HarveyPeachey 0e0c49b
Merge branch 'latest' into most-read-sty-col
HarveyPeachey fdc6991
Updated integration test snapshot
HarveyPeachey ed4bca2
Merge branch 'most-read-sty-col' of https://github.com/bbc/simorgh in…
HarveyPeachey 98c43e2
Merge branch 'latest' into most-read-sty-col
paruchurisilpa edc8d4b
Merge branch 'latest' into most-read-sty-col
HarveyPeachey fbe1ea6
Merge branch 'latest' into most-read-sty-col
paruchurisilpa aded153
Merge branch 'latest' into most-read-sty-col
paruchurisilpa 2bac2a4
Merge branch 'latest' into most-read-sty-col
paruchurisilpa ca0029a
Merge branch 'latest' into most-read-sty-col
amywalkerdev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit strange that it's changing this value from 5 to 10. Will have to make sure this is double-checked in a11y swarm and test phase.