-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump most read tov4 #6029
Bump most read tov4 #6029
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
This might need UX/A11y review since its a major change.
@EinsteinNjoroge |
This PR: #5739 has become active again and includes the major bumps to most read. So I'll be closing this PR. |
Partially Resolves BBC-archive/psammead#3233
Overall change:
Most read going to be bumped in this PR: #5739 but it got held up in UX, therefore, I'm going to bump read separately in this PR.
Code changes:
Testing:
CYPRESS_APP_ENV=local CYPRESS_SMOKE=false npm run test:e2e:interactive
)