-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SIMSBIOHUB-73: Project Details Page Update #192
Conversation
Openshift URLs for the PR Deployment: |
Codecov Report
@@ Coverage Diff @@
## dev #192 +/- ##
==========================================
- Coverage 67.86% 67.72% -0.15%
==========================================
Files 201 205 +4
Lines 5502 5567 +65
Branches 865 881 +16
==========================================
+ Hits 3734 3770 +36
- Misses 1562 1587 +25
- Partials 206 210 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Functionality works great! |
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐱
Project details page and handlebars templates updated
Project details page and handlebars templates updated
…ity Rules Applied (#198) * setup Dialog for security application * basic api security setup * Dialog component setup * Yes No Dialog, cleanup frontend * create connection to api and db. insert and del * remove duplicate securities * pr edits, work still required * Update database/src/migrations/20230531012345_remove_unique_id_artifact_persecution.ts Co-authored-by: Charlie Garrett-Jones <[email protected]> * fix my npm * fix sonar smells/bug * updates, api error still present * Fix winston issue * ignore-skip * add test to repo, fix plural variable * test for repo, service, increase ram * list endpoint test * fix broken delete, FE changes * apply endpoint tested * Further code clean up * initial setup for api to surface artifact security * update review timestamp, restrict access * code smell, allow admin to download * code smell, fix tests * PR Refactor * new branch to avoid git issue * Replicate router enhancements from SIMS (#195) * SIMSBIOHUB-96: Replicate router enhancements from SIMS * SIMSBIOHUB-96: Added makeLoginUrl api util function * Format fix * SIMSBIOHUB-96: Lint fix; remove duplicate code * PR Edits * SIMSBIOHUB-73: Project Details Page Update (#192) Project details page and handlebars templates updated * SIMSBIOHUB-73: Project Details Page Update (#192) Project details page and handlebars templates updated * ignore-skip --------- Co-authored-by: Charlie Garrett-Jones <[email protected]> Co-authored-by: Nick Phura <[email protected]> Co-authored-by: Anissa Agahchen <[email protected]> Co-authored-by: Curtis Upshall <[email protected]> Co-authored-by: Al Rosenthal <[email protected]>
Overview
This PR requires the changes in this PR: PR-1044
Links to Jira tickets
SIMSBIOHUB-73
UXPin
Description of relevant changes
Testing Instructions
PR Checklist
A list of items that are good to consider when making any changes.
Note: this list is not exhaustive, and not all items are always applicable.
Code
Style
Documentation
Tests
Linting/Formatting
See the
lint
commands in package.jsonSee the
format
commands in package.jsonSonarCloud