Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-73: Project Details Page Update #192

Merged
merged 31 commits into from
Jun 15, 2023
Merged

SIMSBIOHUB-73: Project Details Page Update #192

merged 31 commits into from
Jun 15, 2023

Conversation

al-rosenthal
Copy link
Contributor

@al-rosenthal al-rosenthal commented Jun 8, 2023

Overview

This PR requires the changes in this PR: PR-1044

Links to Jira tickets

SIMSBIOHUB-73
UXPin

Description of relevant changes

  • Broke down handlebars template to handle more complex UI
  • Updated data shown in details section of Project Details Page
  • Updated overall layout of Project Details Page
  • Added configuration props to the Map Container

Testing Instructions

  1. Create a project in SIMS (running the code from this PR)
  • Add activities to this project
  • Add IUCN Conservation Actions to this project
  • Add funding sources to this project
  • Add partners to this project
  1. Open BioHub and search for the newly created project
  2. Open details page for that project and see new UI/ changes

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

  • New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
  • I have avoided duplicating code when possible, moving re-usable pieces into functions
  • I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
  • My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
  • My code changes account for null/undefined values and handle errors appropriately
  • My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

  • My code follows the established style conventions
  • My code uses native material-ui components/icons/conventions when possible

Documentation

  • I have commented my code sufficiently, such that an unfamiliar developer could understand my code
  • I have added/updated README's and related documentation, as needed

Tests

  • I have added/updated unit tests for any code I've added/updated
  • I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

  • I have run the linter and fixed any issues, as needed
    See the lint commands in package.json
  • I have run the formatter and fixed any issues, as needed
    See the format commands in package.json

SonarCloud

  • I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #192 (735a389) into dev (f11605d) will decrease coverage by 0.15%.
The diff coverage is 49.12%.

@@            Coverage Diff             @@
##              dev     #192      +/-   ##
==========================================
- Coverage   67.86%   67.72%   -0.15%     
==========================================
  Files         201      205       +4     
  Lines        5502     5567      +65     
  Branches      865      881      +16     
==========================================
+ Hits         3734     3770      +36     
- Misses       1562     1587      +25     
- Partials      206      210       +4     
Impacted Files Coverage Δ
app/src/features/map/MapPage.tsx 38.02% <ø> (ø)
app/src/utils/spatial-utils.tsx 50.00% <ø> (ø)
...components/map/components/StaticLayersControls.tsx 12.50% <12.50%> (ø)
...omponents/map/components/MarkerClusterControls.tsx 27.02% <27.02%> (ø)
app/src/components/map/components/StaticLayers.tsx 68.75% <28.57%> (ø)
app/src/features/datasets/DatasetPage.tsx 59.64% <28.57%> (-2.86%) ⬇️
...pp/src/components/map/components/MarkerCluster.tsx 78.57% <40.00%> (+27.22%) ⬆️
api/src/services/submission-service.ts 88.00% <66.66%> (+0.16%) ⬆️
app/src/utils/handlebarsUtils.ts 42.42% <71.42%> (+4.49%) ⬆️
.../src/paths/dwc/submission/{datasetId}/handlebar.ts 95.23% <95.23%> (ø)
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@anissa-agahchen
Copy link
Contributor

Functionality works great!

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
6.7% 6.7% Duplication

Copy link
Contributor

@KjartanE KjartanE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐱

@al-rosenthal al-rosenthal merged commit 9f8a9b3 into dev Jun 15, 2023
@al-rosenthal al-rosenthal deleted the SIMSBIOHUB-73 branch June 15, 2023 22:10
KjartanE pushed a commit that referenced this pull request Jun 16, 2023
Project details page and handlebars templates updated
KjartanE pushed a commit that referenced this pull request Jun 16, 2023
Project details page and handlebars templates updated
KjartanE added a commit that referenced this pull request Jun 16, 2023
…ity Rules Applied (#198)

* setup Dialog for security application

* basic api security setup

* Dialog component setup

* Yes No Dialog, cleanup frontend

* create connection to api and db. insert and del

* remove duplicate securities

* pr edits, work still required

* Update database/src/migrations/20230531012345_remove_unique_id_artifact_persecution.ts

Co-authored-by: Charlie Garrett-Jones <[email protected]>

* fix my npm

* fix sonar smells/bug

* updates, api error still present

* Fix winston issue

* ignore-skip

* add test to repo, fix plural variable

* test for repo, service, increase ram

* list endpoint test

* fix broken delete, FE changes

* apply endpoint tested

* Further code clean up

* initial setup for api to surface artifact security

* update review timestamp, restrict access

* code smell, allow admin to download

* code smell, fix tests

* PR Refactor

* new branch to avoid git issue

* Replicate router enhancements from SIMS (#195)

* SIMSBIOHUB-96: Replicate router enhancements from SIMS

* SIMSBIOHUB-96: Added makeLoginUrl api util function

* Format fix

* SIMSBIOHUB-96: Lint fix; remove duplicate code

* PR Edits

* SIMSBIOHUB-73: Project Details Page Update (#192)

Project details page and handlebars templates updated

* SIMSBIOHUB-73: Project Details Page Update (#192)

Project details page and handlebars templates updated

* ignore-skip

---------

Co-authored-by: Charlie Garrett-Jones <[email protected]>
Co-authored-by: Nick Phura <[email protected]>
Co-authored-by: Anissa Agahchen <[email protected]>
Co-authored-by: Curtis Upshall <[email protected]>
Co-authored-by: Al Rosenthal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants