SIMSBIOHUB-73: EML generation update

[al-rosenthal]

Overview

Code from this PR: PR-192 depends on this PR

Links to Jira tickets

SIMSBIOHUB-73

Description of relevant changes

• updated EML service to modify data available in the EML generated

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

• New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
• I have avoided duplicating code when possible, moving re-usable pieces into functions
• I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
• My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
• My code changes account for null/undefined values and handle errors appropriately
• My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

• My code follows the established style conventions
• My code uses native material-ui components/icons/conventions when possible

Documentation

• I have commented my code sufficiently, such that an unfamiliar developer could understand my code
• I have added/updated README's and related documentation, as needed

Tests

• I have added/updated unit tests for any code I've added/updated
• I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

• I have run the linter and fixed any issues, as needed
  See the lint commands in package.json
• I have run the formatter and fixed any issues, as needed
  See the format commands in package.json

SonarCloud

• I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-1044-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-1044-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=1044

[codecov]

Codecov Report

Merging #1044 (1c3073d) into dev (a545571) will decrease coverage by 0.02%.
The diff coverage is 7.69%.

@@            Coverage Diff             @@
##              dev    #1044      +/-   ##
==========================================
- Coverage   67.60%   67.59%   -0.02%     
==========================================
  Files         392      392              
  Lines       12228    12232       +4     
  Branches     2096     2096              
==========================================
+ Hits         8267     8268       +1     
- Misses       3442     3445       +3     
  Partials      519      519              

Impacted Files	Coverage Δ
api/src/services/eml-service.ts	45.67% <7.69%> (-0.41%)	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[curtisupshall]

Code looks good!