BugFix: Release Dev to Test #1019

jeznorth · 2023-04-26T22:48:30Z

Overview

Links to Jira tickets

{List all applicable Jira tickets}

Description of relevant changes

{List all relevant changes, in particular anything that will help the reviewers test/verify this PR}

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
I have avoided duplicating code when possible, moving re-usable pieces into functions
I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
My code changes account for null/undefined values and handle errors appropriately
My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

My code follows the established style conventions
My code uses native material-ui components/icons/conventions when possible

Documentation

I have commented my code sufficiently, such that an unfamiliar developer could understand my code
I have added/updated README's and related documentation, as needed

Tests

I have added/updated unit tests for any code I've added/updated
I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

I have run the linter and fixed any issues, as needed
See the lint commands in package.json
I have run the formatter and fixed any issues, as needed
See the format commands in package.json

SonarCloud

I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

github-actions · 2023-04-26T22:50:54Z

Openshift URLs for the PR Deployment:

codecov · 2023-04-26T22:58:10Z

Codecov Report

Merging #1019 (586a61a) into test (10edd6d) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             test    #1019      +/-   ##
==========================================
+ Coverage   68.11%   68.16%   +0.04%     
==========================================
  Files         384      383       -1     
  Lines       11900    11882      -18     
  Branches     2030     2023       -7     
==========================================
- Hits         8106     8099       -7     
+ Misses       3333     3314      -19     
- Partials      461      469       +8

Impacted Files	Coverage Δ
api/src/repositories/user-repository.ts	`97.87% <ø> (ø)`
...rc/components/attachments/list/AttachmentsList.tsx	`81.81% <ø> (ø)`
app/src/components/fields/CustomTextField.tsx	`100.00% <ø> (ø)`
app/src/components/surveys/SurveysList.tsx	`83.33% <ø> (ø)`
app/src/features/projects/edit/EditProjectForm.tsx	`0.00% <ø> (ø)`
...p/src/features/projects/list/ProjectsListTable.tsx	`85.71% <ø> (ø)`
...ures/projects/view/components/LocationBoundary.tsx	`4.68% <ø> (+0.20%)`	⬆️
...t/{projectId}/attachments/{attachmentId}/delete.ts	`97.22% <100.00%> (+0.34%)`	⬆️
api/src/repositories/history-publish-repository.ts	`100.00% <100.00%> (ø)`
api/src/services/history-publish-service.ts	`92.45% <100.00%> (+0.29%)`	⬆️
... and 3 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

… Remove 'Feedback' Functionality (#1016)

Fixed bugs related to deleting surveys, creating a project, duplicate users and various UI changes --------- Co-authored-by: AlfredRosenthal <[email protected]> Co-authored-by: Nick Phura <[email protected]> Co-authored-by: Curtis Upshall <[email protected]>