Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIMS-BIOHUB-8 #1024

Merged
merged 17 commits into from
May 9, 2023
Merged

SIMS-BIOHUB-8 #1024

merged 17 commits into from
May 9, 2023

Conversation

anissa-agahchen
Copy link
Contributor

@anissa-agahchen anissa-agahchen commented Apr 27, 2023 •
edited
Loading

Overview

Links to Jira tickets

https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-8

Description of relevant changes

  • SIMS code changes needed to display file errors when required sheets are missing from a template

Test files for Goat:
content_error_Monashee_Goat.xlsx
NoTabs_Monashee_Goat_2.0 .xlsx
Monashee_Mt_Goat_Total_Count_Recuit_Comp_Survey_2.0.xlsx

@github-actions
Copy link

Openshift URLs for the PR Deployment:

@codecov
Copy link

codecov bot commented Apr 27, 2023 •
edited
Loading

Codecov Report

Merging #1024 (f44ce84) into dev (f3d3d71) will decrease coverage by 0.01%.
The diff coverage is 29.41%.

@@            Coverage Diff             @@
##              dev    #1024      +/-   ##
==========================================
- Coverage   68.35%   68.34%   -0.01%     
==========================================
  Files         383      383              
  Lines       11936    11930       -6     
  Branches     2033     2031       -2     
==========================================
- Hits         8159     8154       -5     
  Misses       3301     3301              
+ Partials      476      475       -1
Impacted Files Coverage Δ
api/src/json-schema/validation-schema.ts 100.00% <ø> (ø)
...d}/survey/{surveyId}/observation/submission/get.ts 84.84% <0.00%> (ø)
.../utils/media/xlsx/transformation/xlsx-transform.ts 3.33% <0.00%> (ø)
api/src/services/summary-service.ts 80.73% <50.00%> (+0.37%) ⬆️
api/src/services/validation-service.ts 81.33% <50.00%> (-0.25%) ⬇️
...rc/utils/media/csv/validation/csv-row-validator.ts 88.33% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@NickPhura NickPhura added the Do Not Merge PR should not be merged label Apr 28, 2023
@anissa-agahchen anissa-agahchen marked this pull request as ready for review May 1, 2023 19:05
@github-actions
Copy link

github-actions bot commented May 1, 2023

Openshift URLs for the PR Deployment:

@anissa-agahchen anissa-agahchen added the Early Feedback Welcome PR is not finished, but early review feedback is welcomed label May 1, 2023
curtisupshall
curtisupshall previously approved these changes May 1, 2023
View reviewed changes
Copy link
Contributor

@curtisupshall curtisupshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good!

@anissa-agahchen anissa-agahchen removed Do Not Merge PR should not be merged Early Feedback Welcome PR is not finished, but early review feedback is welcomed labels May 1, 2023
@KjartanE KjartanE self-assigned this May 2, 2023
AlfredRosenthal
AlfredRosenthal previously approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@AlfredRosenthal AlfredRosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐐

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

AlfredRosenthal
AlfredRosenthal approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@AlfredRosenthal AlfredRosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥮

@AlfredRosenthal AlfredRosenthal merged commit 7c8e44a into dev May 9, 2023
@AlfredRosenthal AlfredRosenthal deleted the SIM-BIOHUB-8 branch May 9, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlfredRosenthal AlfredRosenthal AlfredRosenthal approved these changes

@NickPhura NickPhura NickPhura approved these changes

@curtisupshall curtisupshall Awaiting requested review from curtisupshall

Assignees

@KjartanE KjartanE

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anissa-agahchen @NickPhura @curtisupshall @AlfredRosenthal @KjartanE