Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release Dev to Test #1129

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Release Dev to Test #1129

merged 2 commits into from
Oct 19, 2023

Conversation

KjartanE
Copy link
Contributor

@KjartanE KjartanE commented Oct 19, 2023 •
edited by curtisupshall
Loading

NickPhura and others added 2 commits October 18, 2023 16:18
@NickPhura
SIMSBIOHUB-308: Misc Bug Fixes (#1126)
2960d9b 
* updated open api spec and validation for project/ survey create
* migration to handle deletion of critters and deployments from a survey
* Update GCNotify and Keycloak environment variables
@KjartanE @curtisupshall @NickPhura
SIMSBIOHUB-308: System API User Add Bug (#1127)
69f4781 
* add back removed functionality

* Fixed 'Failed to identify authenticated user' test

* Added back numeric type parser to db

* Fixed remaining tests

---------

Co-authored-by: Curtis Upshall <[email protected]>
Co-authored-by: Nick Phura <[email protected]>
Co-authored-by: Nick Phura <[email protected]>
@github-actions
Copy link

Openshift URLs for the PR Deployment:

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 19, 2023 •
edited
Loading

Codecov Report

Merging #1129 (69f4781) into test (f63d812) will increase coverage by 0.06%.
Report is 29 commits behind head on test.
The diff coverage is 91.48%.

@@            Coverage Diff             @@
##             test    #1129      +/-   ##
==========================================
+ Coverage   63.10%   63.16%   +0.06%     
==========================================
  Files         536      536              
  Lines       16326    16367      +41     
  Branches     2510     2516       +6     
==========================================
+ Hits        10302    10339      +37     
- Misses       5333     5334       +1     
- Partials      691      694       +3
Files Coverage Δ
api/src/database/db-utils.ts 83.87% <100.00%> (+8.87%) ⬆️
api/src/openapi/schemas/project.ts 100.00% <ø> (ø)
api/src/paths/gcnotify/send.ts 78.26% <ø> (ø)
api/src/paths/project/{projectId}/survey/create.ts 96.15% <ø> (ø)
api/src/services/authorization-service.ts 99.06% <100.00%> (+0.01%) ⬆️
api/src/services/keycloak-service.ts 84.37% <100.00%> (-0.48%) ⬇️
api/src/services/platform-service.ts 90.05% <100.00%> (ø)
app/src/features/surveys/CreateSurveyPage.tsx 2.94% <ø> (ø)
app/src/hooks/useKeycloakWrapper.tsx 70.58% <100.00%> (ø)
api/src/paths/user/add.ts 56.41% <50.00%> (ø)
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@NickPhura NickPhura changed the title Dev -> Test : User api Auth changes Release Dev to Test Oct 19, 2023
@NickPhura NickPhura merged commit 0f21439 into test Oct 19, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curtisupshall curtisupshall curtisupshall approved these changes

@NickPhura NickPhura NickPhura approved these changes

@AlfredRosenthal AlfredRosenthal Awaiting requested review from AlfredRosenthal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KjartanE @NickPhura @curtisupshall