SIMSBIOHUB 343 - Incorrect date overlap error in sampling methods #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e overlap check. Also removed an unintended required. Also added a refresh call when submitting sampling method changes so they are reflected in the UI.
|
Openshift URLs for the PR Deployment: |
Codecov Report
@@ Coverage Diff @@
## dev-staging #1144 +/- ##
===============================================
- Coverage 62.13% 62.13% -0.01%
===============================================
Files 554 554
Lines 16914 16915 +1
Branches 2598 2598
===============================================
Hits 10510 10510
- Misses 5697 5698 +1
Partials 707 707
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
curtisupshall
approved these changes
Oct 26, 2023
|
How can I test these changes? Should this be branched from dev, or dev-staging? |
PR needs to rebuild since the base branch changed from |
|
Kudos, SonarCloud Quality Gate passed!
|
curtisupshall
approved these changes
Oct 26, 2023
KjartanE
pushed a commit
that referenced
this pull request
Oct 27, 2023
) * Fixed an issue where the yup schema used for editing sampling methods used the wrong field for a date overlap check. * Removed an unintended required(). * Added a refresh call when submitting sampling method changes so they are reflected in the UI. Otherwise you will still see the previous value if you go back to the sampling methods view even though the new value did save to the db.
KjartanE
added a commit
that referenced
this pull request
Oct 31, 2023
* Add delete sample site button to menu drop down * Check for any associated observations to sample site. * hook up api sample-site delete function. * SIMSBIOHUB-336/337 (#1142) * Adds Sampling Site record count to title area, Example: Sampling Sites (10) * Adds Observation record count to title area of observations map component and manage observations page, Example: Observations (10) * Adds 'supplementaryObservationData' section to get survey observations endpoint. This allows observation record counts to be displayed, even if the get observations response becomes paginated or virtualized at a later date * SIMSBIOHUB 343 - Incorrect date overlap error in sampling methods (#1144) * Fixed an issue where the yup schema used for editing sampling methods used the wrong field for a date overlap check. * Removed an unintended required(). * Added a refresh call when submitting sampling method changes so they are reflected in the UI. Otherwise you will still see the previous value if you go back to the sampling methods view even though the new value did save to the db. * SIMSBIOHUB-334/350/352 (#1143) * Added snackbar popup upon successfully saving observations. * Removed single-click to edit; Fixed bug that made row go into edit mode when clicking row delete icon. * Added seconds to the observation time * Clean up functions and excess data calls * fix tests --------- Co-authored-by: JeremyQuartech <[email protected]> Co-authored-by: GrahamS-Quartech <[email protected]> Co-authored-by: Curtis Upshall <[email protected]>
KjartanE
added a commit
that referenced
this pull request
Nov 6, 2023
* Add delete sample site button to menu drop down * Check for any associated observations to sample site. * hook up api sample-site delete function. * SIMSBIOHUB-336/337 (#1142) * Adds Sampling Site record count to title area, Example: Sampling Sites (10) * Adds Observation record count to title area of observations map component and manage observations page, Example: Observations (10) * Adds 'supplementaryObservationData' section to get survey observations endpoint. This allows observation record counts to be displayed, even if the get observations response becomes paginated or virtualized at a later date * SIMSBIOHUB 343 - Incorrect date overlap error in sampling methods (#1144) * Fixed an issue where the yup schema used for editing sampling methods used the wrong field for a date overlap check. * Removed an unintended required(). * Added a refresh call when submitting sampling method changes so they are reflected in the UI. Otherwise you will still see the previous value if you go back to the sampling methods view even though the new value did save to the db. * SIMSBIOHUB-334/350/352 (#1143) * Added snackbar popup upon successfully saving observations. * Removed single-click to edit; Fixed bug that made row go into edit mode when clicking row delete icon. * Added seconds to the observation time * Clean up functions and excess data calls * fix tests --------- Co-authored-by: JeremyQuartech <[email protected]> Co-authored-by: GrahamS-Quartech <[email protected]> Co-authored-by: Curtis Upshall <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links to Jira Tickets
Description of Changes