Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIMSBIOHUB 343 - Incorrect date overlap error in sampling methods #1145

Closed
wants to merge 2 commits into from
Closed

SIMSBIOHUB 343 - Incorrect date overlap error in sampling methods #1145

wants to merge 2 commits into from

Conversation

curtisupshall
Copy link
Contributor

Re-opening #1144.

Links to Jira Tickets

Description of Changes

  • Fixed an issue where the yup schema used for editing sampling methods used the wrong field for a date overlap check.
  • Removed an unintended required().
  • Added a refresh call when submitting sampling method changes so they are reflected in the UI. Otherwise you will still see the previous value if you go back to the sampling methods view even though the new value did save to the db.

GrahamS-Quartech and others added 2 commits October 26, 2023 11:43
@GrahamS-Quartech
Yup schema in edit sampling method was using wrong field name for dat…
c0bb176 
…e overlap check. Also removed an unintended required. Also added a refresh call when submitting sampling method changes so they are reflected in the UI.
@curtisupshall
SIMSBIOHUB-343: ignore-skip
acc28b4
@curtisupshall curtisupshall mentioned this pull request Oct 26, 2023
Merged
@github-actions
Copy link

Openshift URLs for the PR Deployment:

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@al-rosenthal al-rosenthal Awaiting requested review from al-rosenthal

@NickPhura NickPhura Awaiting requested review from NickPhura

@KjartanE KjartanE Awaiting requested review from KjartanE

@GrahamS-Quartech GrahamS-Quartech Awaiting requested review from GrahamS-Quartech

@JeremyQuartech JeremyQuartech Awaiting requested review from JeremyQuartech

Assignees

@curtisupshall curtisupshall

@GrahamS-Quartech GrahamS-Quartech

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@curtisupshall @GrahamS-Quartech