Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-491: Remove code for project drafts #1216

Merged
merged 56 commits into from
Feb 23, 2024
Merged

Conversation

curtisupshall
Copy link
Contributor

@curtisupshall curtisupshall commented Feb 17, 2024

Overview

Because the project form is no longer comprehensive enough to justify project drafts, we want to remove project drafts from SIMS.

Links to Jira Tickets

Description of Changes

  • Removes all code associated with creating, viewing, and editing project drafts.

Testing Notes

  • You should still be able to:
    • Create a project
    • Edit a project
    • View a project

Copy link

codecov bot commented Feb 17, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 56.43%. Comparing base (8bbccc9) to head (fdadf9c).

Files Patch % Lines
app/src/features/projects/edit/EditProjectPage.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1216      +/-   ##
==========================================
- Coverage   56.82%   56.43%   -0.39%     
==========================================
  Files         586      576      -10     
  Lines       17815    17626     -189     
  Branches     2756     2745      -11     
==========================================
- Hits        10123     9948     -175     
+ Misses       7023     7014       -9     
+ Partials      669      664       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

KjartanE
KjartanE previously approved these changes Feb 21, 2024
Copy link
Contributor

@KjartanE KjartanE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, works as intended. 👍

al-rosenthal
al-rosenthal previously approved these changes Feb 22, 2024
Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ran this locally and it works 📽️

@curtisupshall curtisupshall added Do Not Merge PR should not be merged and removed Ready For Review PR is ready for review labels Feb 22, 2024
Base automatically changed from SIMSBIOHUB-488 to dev February 23, 2024 22:18
@curtisupshall curtisupshall dismissed stale reviews from al-rosenthal and KjartanE February 23, 2024 22:18

The base branch was changed.

@curtisupshall curtisupshall added Ready For Review PR is ready for review and removed Do Not Merge PR should not be merged labels Feb 23, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.2% Duplication on New Code

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@KjartanE KjartanE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐈

Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@curtisupshall curtisupshall merged commit ce90f56 into dev Feb 23, 2024
18 of 19 checks passed
@curtisupshall curtisupshall deleted the SIMSBIOHUB-491 branch February 24, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants