BHBC-1814: Promote Dev to Test

[NickPhura]

Overview

Links to Jira tickets

• {List all applicable Jira tickets}

Description of relevant changes

• {List all relevant changes, in particular anything that will help the reviewers test/verify this PR}

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

• New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
• I have avoided duplicating code when possible, moving re-usable pieces into functions
• I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
• My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
• My code changes account for null/undefined values and handle errors appropriately
• My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

• My code follows the established style conventions
• My code uses native material-ui components/icons/conventions when possible

Documentation

• I have commented my code sufficiently, such that an unfamiliar developer could understand my code
• I have added/updated README's and related documentation, as needed

Tests

• I have added/updated unit tests for any code I've added/updated
• I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

• I have run the linter and fixed any issues, as needed
  See the lint commands in package.json
• I have run the formatter and fixed any issues, as needed
  See the format commands in package.json

SonarCloud

• I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[codecov]

Codecov Report

Merging #796 (1e74bf6) into test (b99f8cb) will decrease coverage by 2.25%.
The diff coverage is 83.80%.

@@            Coverage Diff             @@
##             test     #796      +/-   ##
==========================================
- Coverage   73.05%   70.80%   -2.26%     
==========================================
  Files         353      367      +14     
  Lines       12905    12472     -433     
  Branches     2317     2288      -29     
==========================================
- Hits         9428     8831     -597     
- Misses       2994     3158     +164     
  Partials      483      483              

Impacted Files	Coverage Δ
api/src/__mocks__/db.ts	92.59% <0.00%> (-7.41%)	⬇️
api/src/app.ts	0.00% <0.00%> (ø)
api/src/constants/database.ts	100.00% <ø> (ø)
api/src/openapi/schemas/administrative-activity.ts	100.00% <ø> (ø)
api/src/openapi/schemas/draft.ts	100.00% <ø> (ø)
api/src/openapi/schemas/permit-no-sampling.ts	100.00% <ø> (ø)
api/src/paths/codes.ts	100.00% <ø> (ø)
api/src/paths/dwc/scrape-occurrences.ts	0.00% <ø> (ø)
api/src/paths/dwc/view-occurrences.ts	96.66% <ø> (ø)
.../src/paths/project/{projectId}/attachments/list.ts	96.87% <ø> (ø)
... and 266 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d7e0fa...1e74bf6. Read the comment docs.